Add 'waitUntilExternalURLLoad' method to TestRunner.

Add 'waitUntilExternalURLLoad' method to TestRunner.

This method can be used in layout tests to produce log output and end a
test when the WebFrameClient receives a loadURLExternally() call. This
happens if the content attempts to download a resource explicitly.

Required by Blink CL: https://codereview.chromium.org/197033005/

BUG=346744
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266377

[asanka, 2014-03-14 20:52:57]

Could you take a look?

[dmazzoni, 2014-03-14 21:03:34]

lgtm

This is fine. I'm curious, do you anticipate it'd
ever be useful to get a callback when
loadURLExternally is called, rather than ending the
test?

https://codereview.chromium.org/200663002/diff/1/content/shell/renderer/test_...
File content/shell/renderer/test_runner/WebFrameTestProxy.h (right):

https://codereview.chromium.org/200663002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/WebFrameTestProxy.h:52: virtual void
loadURLExternally(blink::WebFrame* frame, const blink::WebURLRequest& request,
blink::WebNavigationPolicy policy, const blink::WebString& suggested_name)
Could you add OVERRIDE to all of the functions that implement WebFrameClient
while you're at it?

[asanka, 2014-03-14 21:45:24]

On 2014/03/14 21:03:34, dmazzoni wrote:
> lgtm
> 
> This is fine. I'm curious, do you anticipate it'd
> ever be useful to get a callback when
> loadURLExternally is called, rather than ending the
> test?

I was wondering whether that would be worthwhile for cases where we expect
multiple loadURLExternally() calls in the same test. But I decided against it
since the need isn't there to justify the additional complexity.

>
https://codereview.chromium.org/200663002/diff/1/content/shell/renderer/test_...
> File content/shell/renderer/test_runner/WebFrameTestProxy.h (right):
> 
>
https://codereview.chromium.org/200663002/diff/1/content/shell/renderer/test_...
> content/shell/renderer/test_runner/WebFrameTestProxy.h:52: virtual void
> loadURLExternally(blink::WebFrame* frame, const blink::WebURLRequest& request,
> blink::WebNavigationPolicy policy, const blink::WebString& suggested_name)
> Could you add OVERRIDE to all of the functions that implement WebFrameClient
> while you're at it?

[asanka, 2014-03-14 21:45:31]

https://codereview.chromium.org/200663002/diff/1/content/shell/renderer/test_...
File content/shell/renderer/test_runner/WebFrameTestProxy.h (right):

https://codereview.chromium.org/200663002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/WebFrameTestProxy.h:52: virtual void
loadURLExternally(blink::WebFrame* frame, const blink::WebURLRequest& request,
blink::WebNavigationPolicy policy, const blink::WebString& suggested_name)
On 2014/03/14 21:03:35, dmazzoni wrote:
> Could you add OVERRIDE to all of the functions that implement WebFrameClient
> while you're at it?

Done.

[jochen (gone - plz use gerrit), 2014-03-16 12:55:44]

note that TestRunner.cpp no longer exists..

https://codereview.chromium.org/200663002/diff/20001/content/shell/renderer/t...
File content/shell/renderer/test_runner/WebFrameTestProxy.h (right):

https://codereview.chromium.org/200663002/diff/20001/content/shell/renderer/t...
content/shell/renderer/test_runner/WebFrameTestProxy.h:50: virtual void
didStartProvisionalLoad(blink::WebFrame* frame) OVERRIDE
we don't put OVERRIDE on implementations of the blink API, because it makes
refactoring the blink API super painful

[asanka, 2014-03-19 20:38:39]

On 2014/03/16 12:55:44, jochen wrote:
> note that TestRunner.cpp no longer exists..
> 
>
https://codereview.chromium.org/200663002/diff/20001/content/shell/renderer/t...
> File content/shell/renderer/test_runner/WebFrameTestProxy.h (right):
> 
>
https://codereview.chromium.org/200663002/diff/20001/content/shell/renderer/t...
> content/shell/renderer/test_runner/WebFrameTestProxy.h:50: virtual void
> didStartProvisionalLoad(blink::WebFrame* frame) OVERRIDE
> we don't put OVERRIDE on implementations of the blink API, because it makes
> refactoring the blink API super painful

Ah. Thanks. However, looks like the Blink side of the logic is going to have to
be moved to content anyway. So we won't be needing this change to the
test_runner.

[asanka, 2014-04-23 19:31:53]

dmazzoni, jochen: I revived this CL and updated it to keep up with the changes
to test_runner. Also I removed OVERRIDE. Could you take another look? The
test_runner changes are new.

[jochen (gone - plz use gerrit), 2014-04-24 12:52:49]

lgtm

https://codereview.chromium.org/200663002/diff/80001/content/shell/renderer/t...
File content/shell/renderer/test_runner/test_runner.cc (right):

https://codereview.chromium.org/200663002/diff/80001/content/shell/renderer/t...
content/shell/renderer/test_runner/test_runner.cc:2491: 
only one empty line

[asanka, 2014-04-24 18:23:35]

Thanks!

https://codereview.chromium.org/200663002/diff/80001/content/shell/renderer/t...
File content/shell/renderer/test_runner/test_runner.cc (right):

https://codereview.chromium.org/200663002/diff/80001/content/shell/renderer/t...
content/shell/renderer/test_runner/test_runner.cc:2491: 
On 2014/04/24 12:52:49, jochen wrote:
> only one empty line

Done.

[asanka, 2014-04-24 19:54:23]

The CQ bit was checked by asanka@chromium.org

[asanka, 2014-04-24 21:29:21]

The CQ bit was unchecked by asanka@chromium.org

[asanka, 2014-04-24 21:29:24]

The CQ bit was checked by asanka@chromium.org

[commit-bot: I haz the power, 2014-04-24 21:43:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asanka@chromium.org/200663002/100001

[commit-bot: I haz the power, 2014-04-24 23:07:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 23:07:17]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[asanka, 2014-04-25 14:00:35]

The CQ bit was checked by asanka@chromium.org

[asanka, 2014-04-25 19:48:06]

The CQ bit was unchecked by asanka@chromium.org

[asanka, 2014-04-25 19:48:08]

The CQ bit was checked by asanka@chromium.org

[asanka, 2014-04-25 21:40:55]

The CQ bit was unchecked by asanka@chromium.org

[asanka, 2014-04-25 21:41:03]

The CQ bit was checked by asanka@chromium.org

[commit-bot: I haz the power, 2014-04-25 21:42:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asanka@chromium.org/200663002/100001

[commit-bot: I haz the power, 2014-04-26 22:07:34]

Change committed as 266377