Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2006613002: [turbofan] Lower intrinsics %_GeneratorGetInput and %_GeneratorGetResumeMode. (Closed)

Created:
4 years, 7 months ago by neis
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Intrinsic-lowering for GeneratorGetInput and GeneratorGetResumeMode. Also use the inlined version of CreateIterResultObject in Ignition's VisitYield. BUG=v8:4907 TBR=littledan@chromium.org Committed: https://crrev.com/1292721f923e53a700fec77861b17e48ced85752 Cr-Commit-Position: refs/heads/master@{#36444}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -20 lines) Patch
M src/compiler/access-builder.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +24 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/parsing/parser.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 10 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006613002/1
4 years, 7 months ago (2016-05-23 08:27:01 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-23 09:02:57 UTC) #8
neis
ptal
4 years, 7 months ago (2016-05-23 09:04:04 UTC) #9
rmcilroy
Interpreter changes LGTM. [Future work suggestion - you could add _GeneratorGetInput and _GeneratorGetResumeMode to the ...
4 years, 7 months ago (2016-05-23 11:17:31 UTC) #10
Jarin
lgtm
4 years, 7 months ago (2016-05-23 13:56:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006613002/1
4 years, 7 months ago (2016-05-23 14:18:55 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 14:20:56 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 14:22:59 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1292721f923e53a700fec77861b17e48ced85752
Cr-Commit-Position: refs/heads/master@{#36444}

Powered by Google App Engine
This is Rietveld 408576698