Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Unified Diff: runtime/lib/mirrors_impl.dart

Issue 20066004: Change the return value of setField to be in line with non-reflective assignments. Complete unwrapp… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/tests/vm/dart/isolate_mirror_local_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors_impl.dart
===================================================================
--- runtime/lib/mirrors_impl.dart (revision 25456)
+++ runtime/lib/mirrors_impl.dart (working copy)
@@ -194,9 +194,10 @@
}
InstanceMirror setField(Symbol memberName, Object value) {
- return reflect(this._invokeSetter(_reflectee,
- _n(memberName),
- value));
+ this._invokeSetter(_reflectee,
+ _n(memberName),
+ value);
+ return reflect(value);
}
Future<InstanceMirror> invokeAsync(Symbol memberName,
@@ -239,10 +240,10 @@
"a simple value or InstanceMirror";
}
- var result = this._invokeSetter(_reflectee,
- _n(memberName),
- unwrappedValue);
- return new Future.value(reflect(result));
+ this._invokeSetter(_reflectee,
+ _n(memberName),
+ unwrappedValue);
+ return new Future.value(reflect(unwrappedValue));
} catch(e) {
return new Future.error(e);
}
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/tests/vm/dart/isolate_mirror_local_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698