Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 20066: Move resource_message_filter and resource_request_details to the renderer_hos... (Closed)

Created:
11 years, 10 months ago by brettw
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Move resource_message_filter and resource_request_details to the renderer_host. Make the repost form warning portable by abstracting the show function from the view. Rename the Windows repost form warning and move it to browser/views. This also fixes a comment in browser_process.h Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9242

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -1351 lines) Patch
M chrome/browser/browser.scons View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/browser.vcproj View 5 chunks +18 lines, -22 lines 0 comments Download
M chrome/browser/browser_process.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/plugin_process_host.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/plugin_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/renderer_host/resource_message_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/renderer_host/resource_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/renderer_host/resource_request_details.h View 3 chunks +4 lines, -5 lines 0 comments Download
D chrome/browser/repost_form_warning_dialog.h View 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/repost_form_warning_dialog.cc View 1 chunk +0 lines, -109 lines 0 comments Download
D chrome/browser/resource_message_filter.h View 1 chunk +0 lines, -244 lines 0 comments Download
D chrome/browser/resource_message_filter.cc View 1 chunk +0 lines, -741 lines 0 comments Download
D chrome/browser/resource_request_details.h View 1 chunk +0 lines, -87 lines 0 comments Download
M chrome/browser/ssl/ssl_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/navigation_controller.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A chrome/browser/tab_contents/repost_form_warning.h View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/browser/task_manager_resource_providers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/browser_views.vcproj View 1 chunk +8 lines, -0 lines 0 comments Download
A + chrome/browser/views/repost_form_warning_view.h View 4 chunks +9 lines, -13 lines 0 comments Download
A + chrome/browser/views/repost_form_warning_view.cc View 4 chunks +40 lines, -43 lines 0 comments Download
M chrome/chrome.xcodeproj/project.pbxproj View 7 chunks +10 lines, -10 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
brettw
11 years, 10 months ago (2009-02-05 00:34:43 UTC) #1
pink (ping after 24hrs)
11 years, 10 months ago (2009-02-05 01:44:24 UTC) #2 
LGTM.

http://codereview.chromium.org/20066/diff/1/11
File chrome/chrome.xcodeproj/project.pbxproj (right):

http://codereview.chromium.org/20066/diff/1/11#newcode4705
Line 4705: A7A211750F3A248300F62B4D /* resource_message_filter.cc in Sources */,
alphabetize.

Powered by Google App Engine
This is Rietveld 408576698