Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: third_party/WebKit/Source/modules/webaudio/PannerNode.h

Issue 2006563003: Simplify notification of a dirty listener. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix typo Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010, Google Inc. All rights reserved. 2 * Copyright (C) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 double coneInnerAngle() const { return m_coneEffect.innerAngle(); } 97 double coneInnerAngle() const { return m_coneEffect.innerAngle(); }
98 void setConeInnerAngle(double); 98 void setConeInnerAngle(double);
99 99
100 double coneOuterAngle() const { return m_coneEffect.outerAngle(); } 100 double coneOuterAngle() const { return m_coneEffect.outerAngle(); }
101 void setConeOuterAngle(double); 101 void setConeOuterAngle(double);
102 102
103 double coneOuterGain() const { return m_coneEffect.outerGain(); } 103 double coneOuterGain() const { return m_coneEffect.outerGain(); }
104 void setConeOuterGain(double); 104 void setConeOuterGain(double);
105 105
106 void markPannerAsDirty(unsigned); 106 void markPannerAsDirty(unsigned);
107 void updateDirtyState();
108 107
109 double tailTime() const override { return m_panner ? m_panner->tailTime() : 0; } 108 double tailTime() const override { return m_panner ? m_panner->tailTime() : 0; }
110 double latencyTime() const override { return m_panner ? m_panner->latencyTim e() : 0; } 109 double latencyTime() const override { return m_panner ? m_panner->latencyTim e() : 0; }
111 110
112 void setChannelCount(unsigned long, ExceptionState&) final; 111 void setChannelCount(unsigned long, ExceptionState&) final;
113 void setChannelCountMode(const String&, ExceptionState&) final; 112 void setChannelCountMode(const String&, ExceptionState&) final;
114 113
115 private: 114 private:
116 PannerHandler( 115 PannerHandler(
117 AudioNode&, 116 AudioNode&,
(...skipping 23 matching lines...) Expand all
141 float calculateDistanceConeGain( 140 float calculateDistanceConeGain(
142 const FloatPoint3D& position, 141 const FloatPoint3D& position,
143 const FloatPoint3D& orientation, 142 const FloatPoint3D& orientation,
144 const FloatPoint3D& listenerPosition); 143 const FloatPoint3D& listenerPosition);
145 144
146 void azimuthElevation(double* outAzimuth, double* outElevation); 145 void azimuthElevation(double* outAzimuth, double* outElevation);
147 float distanceConeGain(); 146 float distanceConeGain();
148 147
149 bool isAzimuthElevationDirty() const { return m_isAzimuthElevationDirty; } 148 bool isAzimuthElevationDirty() const { return m_isAzimuthElevationDirty; }
150 bool isDistanceConeGainDirty() const { return m_isDistanceConeGainDirty; } 149 bool isDistanceConeGainDirty() const { return m_isDistanceConeGainDirty; }
150 void updateDirtyState();
151 151
152 // This Persistent doesn't make a reference cycle including the owner 152 // This Persistent doesn't make a reference cycle including the owner
153 // PannerNode. 153 // PannerNode.
154 Persistent<AudioListener> m_listener; 154 Persistent<AudioListener> m_listener;
155 OwnPtr<Panner> m_panner; 155 OwnPtr<Panner> m_panner;
156 unsigned m_panningModel; 156 unsigned m_panningModel;
157 unsigned m_distanceModel; 157 unsigned m_distanceModel;
158 158
159 bool m_isAzimuthElevationDirty; 159 bool m_isAzimuthElevationDirty;
160 bool m_isDistanceConeGainDirty; 160 bool m_isDistanceConeGainDirty;
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 Member<AudioParam> m_positionZ; 248 Member<AudioParam> m_positionZ;
249 249
250 Member<AudioParam> m_orientationX; 250 Member<AudioParam> m_orientationX;
251 Member<AudioParam> m_orientationY; 251 Member<AudioParam> m_orientationY;
252 Member<AudioParam> m_orientationZ; 252 Member<AudioParam> m_orientationZ;
253 }; 253 };
254 254
255 } // namespace blink 255 } // namespace blink
256 256
257 #endif // PannerNode_h 257 #endif // PannerNode_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698