Moved Sublime documentation to markdown and added SublimeClang setup

Moved Sublime documentation to markdown and added SublimeClang setup

Moved the Sublime Text setup documentation from the wiki (at
https://www.chromium.org/developers/sublime-text) to the new markdown
format, storing the docs in /docs and the scripts (which were previously
included as attachments on the wiki page) in /tools/sublime. Copied
across all existing documentation and updated instructions where
necessary.

Also added instructions for a new Linux-only SublimeClang setup that
enables function and type autocompletion and error detection on save.

Setup tested manually with alancutter@ and nainar@, and hopefully more
testing will occur once these instructions are distributed, and lead to
further improvements in the setup instructions through collaboration.

Committed: https://crrev.com/4fe2e1d461db5a5a48b323c8b6a349ccbdd2fc05
Cr-Commit-Position: refs/heads/master@{#396342}

[sashab, 2016-05-23 05:32:52]

Description was changed from

==========
Moved Sublime documentation to markdown and added SublimeClang setup

Moved the Sublime Text setup documentation to the new markdown format.
Copied across all existing documentation and updated it where necessary.

Also added instructions for a new Linux-only SublimeClang setup that
enables function and type autocompletion and error detection on save.

Setup tested manually with alancutter@ and nainar@, and hopefully more
testing will occur once these instructions are distributed, and lead to
further improvements in the setup instructions through collaboration.
==========

to

==========
Moved Sublime documentation to markdown and added SublimeClang setup

Moved the Sublime Text setup documentation to the new markdown format,
including scripts that were previously included as attachments. Copied
across all existing documentation and updated instructions where
necessary.

Also added instructions for a new Linux-only SublimeClang setup that
enables function and type autocompletion and error detection on save.

Setup tested manually with alancutter@ and nainar@, and hopefully more
testing will occur once these instructions are distributed, and lead to
further improvements in the setup instructions through collaboration.
==========

[sashab, 2016-05-23 05:33:21]

sashab@chromium.org changed reviewers:
+ alancutter@chromium.org, thakis@chromium.org

[sashab, 2016-05-23 05:33:39]

alancutter@ for quick look please; thakis@ for full review :)

[alancutter (OOO until 2018), 2016-05-23 07:31:03]

The description should link to the page it's deprecating: 
https://www.chromium.org/developers/sublime-text

https://codereview.chromium.org/2006563002/diff/1/docs/scripts/ninja_options_...
File docs/scripts/ninja_options_script.py (right):

https://codereview.chromium.org/2006563002/diff/1/docs/scripts/ninja_options_...
docs/scripts/ninja_options_script.py:7: #   "sublimeclang_options_script":
"python /path/to/ninja_options_script.py \
This could be ${project_path}/src/docs/scripts/ninja_options_script.py.

https://codereview.chromium.org/2006563002/diff/1/docs/scripts/ninja_options_...
docs/scripts/ninja_options_script.py:9: #                                  
${project_path}/src/out/Debug"
Mention that ${project_path} expands to the directory of the Sublime project
file.

https://codereview.chromium.org/2006563002/diff/1/docs/scripts/ninja_options_...
docs/scripts/ninja_options_script.py:112: file_path = sys.argv[3]
The example in the comment at the top only passes in two arguments yet three are
read here, won't it hit an IndexError?

[Nico, 2016-05-23 13:57:54]

since the cl description says "moved", say where you moved this from (i guess
the sites page or the wiki?), ideally with a link. Say why you're moving it as
well. (If people who use sublime prefer their docs in docs/ that's reason
enough, but cl descriptions should answer "why?")

I think the .py files shouldn't be in docs/ but in tools/sublime (next to
tools/vim and tools/emacs).

https://codereview.chromium.org/2006563002/diff/1/docs/scripts/compile_curren...
File docs/scripts/compile_current_file.py (right):

https://codereview.chromium.org/2006563002/diff/1/docs/scripts/compile_curren...
docs/scripts/compile_current_file.py:223: source_object_filename =
os.path.splitext(source_filename)[0] + '.o'
fwiw, passing "../../path/to/file.cc^" (with the caret) means "build first
output with that file as input" and is a bit more reliable than the .o bit (I
think this script as-is probably will work with only one of gyp and gn, and it
won't work on windows)

[sashab, 2016-05-24 01:36:33]

Description was changed from

==========
Moved Sublime documentation to markdown and added SublimeClang setup

Moved the Sublime Text setup documentation to the new markdown format,
including scripts that were previously included as attachments. Copied
across all existing documentation and updated instructions where
necessary.

Also added instructions for a new Linux-only SublimeClang setup that
enables function and type autocompletion and error detection on save.

Setup tested manually with alancutter@ and nainar@, and hopefully more
testing will occur once these instructions are distributed, and lead to
further improvements in the setup instructions through collaboration.
==========

to

==========
Moved Sublime documentation to markdown and added SublimeClang setup

Moved the Sublime Text setup documentation from the wiki (at
https://www.chromium.org/developers/sublime-text) to the new markdown
format, storing the docs in /docs and the scripts (which were previously
included as attachments on the wiki page) in /tools/sublime. Copied
across all existing documentation and updated instructions where
necessary.

Also added instructions for a new Linux-only SublimeClang setup that
enables function and type autocompletion and error detection on save.

Setup tested manually with alancutter@ and nainar@, and hopefully more
testing will occur once these instructions are distributed, and lead to
further improvements in the setup instructions through collaboration.
==========

[sashab, 2016-05-24 01:36:53]

Done all comments :)

[alancutter (OOO until 2018), 2016-05-24 01:38:37]

https://codereview.chromium.org/2006563002/diff/20001/tools/sublime/ninja_opt...
File tools/sublime/ninja_options_script.py (right):

https://codereview.chromium.org/2006563002/diff/20001/tools/sublime/ninja_opt...
tools/sublime/ninja_options_script.py:117: file_path = sys.argv[3]
This still appears to be reading three arguments when the example on line 7 only
provides two.

[Nico, 2016-05-24 16:42:14]

lgtm once alancutter is happy

https://codereview.chromium.org/2006563002/diff/60001/tools/sublime/compile_c...
File tools/sublime/compile_current_file.py (right):

https://codereview.chromium.org/2006563002/diff/60001/tools/sublime/compile_c...
tools/sublime/compile_current_file.py:38: 
(fwiw, python style guide says "two blank lines between toplevel things")

https://codereview.chromium.org/2006563002/diff/60001/tools/sublime/compile_c...
tools/sublime/compile_current_file.py:213: ninja_path =
find_ninja_file(output_dir, file_relative_path)
Hm, this should always be in output_dir/build.ninja, I wonder why it does this
roundabout searching for a non-toplevel ninja file

[sashab, 2016-05-25 01:30:00]

Thanks Nico :) Alan PTAL

https://codereview.chromium.org/2006563002/diff/20001/tools/sublime/ninja_opt...
File tools/sublime/ninja_options_script.py (right):

https://codereview.chromium.org/2006563002/diff/20001/tools/sublime/ninja_opt...
tools/sublime/ninja_options_script.py:117: file_path = sys.argv[3]
On 2016/05/24 at 01:38:36, alancutter wrote:
> This still appears to be reading three arguments when the example on line 7
only provides two.

sys.argv[0] is the script itself. This is consistent with argv in C++. :-)

https://codereview.chromium.org/2006563002/diff/60001/tools/sublime/compile_c...
File tools/sublime/compile_current_file.py (right):

https://codereview.chromium.org/2006563002/diff/60001/tools/sublime/compile_c...
tools/sublime/compile_current_file.py:38: 
On 2016/05/24 at 16:42:14, Nico wrote:
> (fwiw, python style guide says "two blank lines between toplevel things")

Ahh, thanks. Good to be consistent. :)

https://codereview.chromium.org/2006563002/diff/60001/tools/sublime/compile_c...
tools/sublime/compile_current_file.py:213: ninja_path =
find_ninja_file(output_dir, file_relative_path)
On 2016/05/24 at 16:42:14, Nico wrote:
> Hm, this should always be in output_dir/build.ninja, I wonder why it does this
roundabout searching for a non-toplevel ninja file

It's trying to find the current file, not the current target.
out_dir/build.ninja has a list of targets but no specific files that make these
targets.

out_dir/build.ninja:
build redirection_header: phony obj/sql/redirection_header.stamp
build regexp_fuzzer: phony obj/v8/regexp_fuzzer.stamp
build registry_controlled_domains: phony
obj/net/base/registry_controlled_domains/registry_controlled_domains.stamp
build remaining: phony obj/third_party/WebKit/Source/core/remaining.stamp
build remote_bitrate_estimator: phony
obj/third_party/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.stamp

remaining.ninja:
uild obj/third_party/WebKit/Source/core/remaining/CoreInitializer.o: cxx
../../third_party/WebKit/Source/core/CoreInitializer.cpp ||
obj/third_party/WebKit/Source/core/remaining.inputdeps.stamp
build obj/third_party/WebKit/Source/core/remaining/KeyframeEffect.o: cxx
../../third_party/WebKit/Source/core/animation/KeyframeEffect.cpp ||
obj/third_party/WebKit/Source/core/remaining.inputdeps.stamp
build obj/third_party/WebKit/Source/core/remaining/AnimationClock.o: cxx
../../third_party/WebKit/Source/core/animation/AnimationClock.cpp ||
obj/third_party/WebKit/Source/core/remaining.inputdeps.stamp
build obj/third_party/WebKit/Source/core/remaining/AnimationInputHelpers.o: cxx
../../third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp ||
obj/third_party/WebKit/Source/core/remaining.inputdeps.stamp
build obj/third_party/WebKit/Source/core/remaining/AnimationEffect.o: cxx
../../third_party/WebKit/Source/core/animation/AnimationEffect.cpp ||
obj/third_party/WebKit/Source/core/remaining.inputdeps.stamp

[Nico, 2016-05-25 01:39:22]

https://codereview.chromium.org/2006563002/diff/60001/tools/sublime/compile_c...
File tools/sublime/compile_current_file.py (right):

https://codereview.chromium.org/2006563002/diff/60001/tools/sublime/compile_c...
tools/sublime/compile_current_file.py:213: ninja_path =
find_ninja_file(output_dir, file_relative_path)
On 2016/05/25 01:30:00, sashab wrote:
> On 2016/05/24 at 16:42:14, Nico wrote:
> > Hm, this should always be in output_dir/build.ninja, I wonder why it does
this
> roundabout searching for a non-toplevel ninja file
> 
> It's trying to find the current file, not the current target.
> out_dir/build.ninja has a list of targets but no specific files that make
these
> targets.
> 
> out_dir/build.ninja:
> build redirection_header: phony obj/sql/redirection_header.stamp
> build regexp_fuzzer: phony obj/v8/regexp_fuzzer.stamp
> build registry_controlled_domains: phony
> obj/net/base/registry_controlled_domains/registry_controlled_domains.stamp
> build remaining: phony obj/third_party/WebKit/Source/core/remaining.stamp
> build remote_bitrate_estimator: phony
>
obj/third_party/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.stamp
> 
> remaining.ninja:
> uild obj/third_party/WebKit/Source/core/remaining/CoreInitializer.o: cxx
> ../../third_party/WebKit/Source/core/CoreInitializer.cpp ||
> obj/third_party/WebKit/Source/core/remaining.inputdeps.stamp
> build obj/third_party/WebKit/Source/core/remaining/KeyframeEffect.o: cxx
> ../../third_party/WebKit/Source/core/animation/KeyframeEffect.cpp ||
> obj/third_party/WebKit/Source/core/remaining.inputdeps.stamp
> build obj/third_party/WebKit/Source/core/remaining/AnimationClock.o: cxx
> ../../third_party/WebKit/Source/core/animation/AnimationClock.cpp ||
> obj/third_party/WebKit/Source/core/remaining.inputdeps.stamp
> build obj/third_party/WebKit/Source/core/remaining/AnimationInputHelpers.o:
cxx
> ../../third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp ||
> obj/third_party/WebKit/Source/core/remaining.inputdeps.stamp
> build obj/third_party/WebKit/Source/core/remaining/AnimationEffect.o: cxx
> ../../third_party/WebKit/Source/core/animation/AnimationEffect.cpp ||
> obj/third_party/WebKit/Source/core/remaining.inputdeps.stamp

Yes, but why is this needed? Just `ninja -C out/Release
../../base/strings/string16.cc^` should be all that's needed to build
string16.o, no need to find remaining.ninja for that

[sashab, 2016-05-25 04:08:02]

Sorry; I understand what you meant now thakis@! Fixed :)

[alancutter (OOO until 2018), 2016-05-26 02:06:09]

lgtm

https://codereview.chromium.org/2006563002/diff/20001/tools/sublime/ninja_opt...
File tools/sublime/ninja_options_script.py (right):

https://codereview.chromium.org/2006563002/diff/20001/tools/sublime/ninja_opt...
tools/sublime/ninja_options_script.py:117: file_path = sys.argv[3]
On 2016/05/25 at 01:30:00, sashab wrote:
> On 2016/05/24 at 01:38:36, alancutter wrote:
> > This still appears to be reading three arguments when the example on line 7
only provides two.
> 
> sys.argv[0] is the script itself. This is consistent with argv in C++. :-)

My mistake, I didn't realise the script caller would provide the current file
path as a third argument.

[sashab, 2016-05-27 00:17:01]

The CQ bit was checked by sashab@chromium.org

[sashab, 2016-05-27 00:17:02]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2006563002/#ps100001
(title: "Removed unecessary steps in compile work")

[commit-bot: I haz the power, 2016-05-27 00:17:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2006563002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2006563002/100001

[commit-bot: I haz the power, 2016-05-27 01:17:59]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-05-27 01:19:23]

Description was changed from

==========
Moved Sublime documentation to markdown and added SublimeClang setup

Moved the Sublime Text setup documentation from the wiki (at
https://www.chromium.org/developers/sublime-text) to the new markdown
format, storing the docs in /docs and the scripts (which were previously
included as attachments on the wiki page) in /tools/sublime. Copied
across all existing documentation and updated instructions where
necessary.

Also added instructions for a new Linux-only SublimeClang setup that
enables function and type autocompletion and error detection on save.

Setup tested manually with alancutter@ and nainar@, and hopefully more
testing will occur once these instructions are distributed, and lead to
further improvements in the setup instructions through collaboration.
==========

to

==========
Moved Sublime documentation to markdown and added SublimeClang setup

Moved the Sublime Text setup documentation from the wiki (at
https://www.chromium.org/developers/sublime-text) to the new markdown
format, storing the docs in /docs and the scripts (which were previously
included as attachments on the wiki page) in /tools/sublime. Copied
across all existing documentation and updated instructions where
necessary.

Also added instructions for a new Linux-only SublimeClang setup that
enables function and type autocompletion and error detection on save.

Setup tested manually with alancutter@ and nainar@, and hopefully more
testing will occur once these instructions are distributed, and lead to
further improvements in the setup instructions through collaboration.

Committed: https://crrev.com/4fe2e1d461db5a5a48b323c8b6a349ccbdd2fc05
Cr-Commit-Position: refs/heads/master@{#396342}
==========

[commit-bot: I haz the power, 2016-05-27 01:19:24]

Patchset 6 (id:??) landed as
https://crrev.com/4fe2e1d461db5a5a48b323c8b6a349ccbdd2fc05
Cr-Commit-Position: refs/heads/master@{#396342}

[chromium-reviews, 2016-05-27 01:45:07]

Updated https://www.chromium.org/developers/sublime-text

On Fri, May 27, 2016 at 11:19 AM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Patchset 6 (id:??) landed as
> https://crrev.com/4fe2e1d461db5a5a48b323c8b6a349ccbdd2fc05
> Cr-Commit-Position: refs/heads/master@{#396342}
>
> https://codereview.chromium.org/2006563002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.