Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2006543002: Rebaseline fast/text/midword-break-after-breakable-char.html for Mac (Closed)

Created:
4 years, 7 months ago by kojii
Modified:
4 years, 7 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rebaseline fast/text/midword-break-after-breakable-char.html for Mac The previous rebaseline did not work, but the test results look good, just need to rebaseline correctly. BUG=604642 Committed: https://crrev.com/08ed079bdfd2490f4f3f02e09785abd41c604fb1 Cr-Commit-Position: refs/heads/master@{#395333}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (10 generated)
kojii
PTAL. Not sure why the first rebaseline failed, should I go to manual-rebaseline, or try ...
4 years, 7 months ago (2016-05-23 04:58:32 UTC) #3
tkent
lgtm
4 years, 7 months ago (2016-05-23 05:02:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006543002/1
4 years, 7 months ago (2016-05-23 05:05:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/233584)
4 years, 7 months ago (2016-05-23 06:38:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006543002/1
4 years, 7 months ago (2016-05-23 06:44:24 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/233618)
4 years, 7 months ago (2016-05-23 09:07:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006543002/1
4 years, 7 months ago (2016-05-23 09:33:33 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/233698)
4 years, 7 months ago (2016-05-23 11:55:58 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006543002/1
4 years, 7 months ago (2016-05-23 15:43:03 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 15:46:37 UTC) #19
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 15:48:08 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08ed079bdfd2490f4f3f02e09785abd41c604fb1
Cr-Commit-Position: refs/heads/master@{#395333}

Powered by Google App Engine
This is Rietveld 408576698