Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2006503002: Reland of Mark removable Drive caches for cryptohome. (Closed)

Created:
4 years, 7 months ago by oka
Modified:
4 years, 7 months ago
Reviewers:
hashimoto, yawano
CC:
chromium-reviews, oshima+watch_chromium.org, fukino, yawano
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Mark removable Drive caches for cryptohome. (patchset #2 id:80001 of https://codereview.chromium.org/1989863005/ ) Reason for revert: Reland for M53. BUG=533750 Original issue's description: > Revert of Mark removable Drive caches for cryptohome. (patchset #17 id:320001 of https://codereview.chromium.org/1918243004/ ) > > Reason for revert: > Corresponding changes for Chrome OS [1] haven't been submitted. Let's punt this change to M53. > [1] https://chromium-review.googlesource.com/#/c/343538/ > > Original issue's description: > > Mark removable Drive caches for cryptohome. > > > > Design doc: https://docs.google.com/document/d/1Kdq-b5kpudbotQ1q2GRNd52f-oZUrf7mfuZb1XUqH4U/edit#heading=h.sa3sh9r88p48 > > > > - Mark the Drive cache dir with +d (chattr) and user.GCacheFiles (setxattr), and mark removable files in it with +d. > > - Toggle the status of metadata if cache files have been removed by > > cryptohome. > > - Remove a file if it exsits but metadata says not (inconsistency possibly happens on abrupt shutdown). > > - Toggle +d as necessary when pinned/dirty status are changed. > > > > Committed: https://crrev.com/1d5bdf653f3859d29ae3b6ad7535cefc3702f45d > > Cr-Commit-Position: refs/heads/master@{#393229} > > TBR=hashimoto@chromium.org,yawano@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > > Committed: https://crrev.com/29e3ff432556adf39449824074e1032afb4de27f > Cr-Commit-Position: refs/heads/master@{#394720} TBR=hashimoto@chromium.org,yawano@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/c6aac5025193119560369c1f3ca099a35f8ea86d Cr-Commit-Position: refs/heads/master@{#395304}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -174 lines) Patch
M components/drive/chromeos/file_cache.h View 3 chunks +9 lines, -8 lines 0 comments Download
M components/drive/chromeos/file_cache.cc View 12 chunks +158 lines, -40 lines 0 comments Download
M components/drive/chromeos/file_cache_unittest.cc View 12 chunks +123 lines, -126 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
oka
Created Reland of Mark removable Drive caches for cryptohome.
4 years, 7 months ago (2016-05-22 22:43:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006503002/1
4 years, 7 months ago (2016-05-22 22:43:51 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-22 22:43:53 UTC) #4
oka
PTAL. It requires LGTM since I'm not a full committer.
4 years, 7 months ago (2016-05-23 04:41:31 UTC) #6
hashimoto
lgtm
4 years, 7 months ago (2016-05-23 05:45:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006503002/1
4 years, 7 months ago (2016-05-23 08:07:33 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/233648)
4 years, 7 months ago (2016-05-23 10:46:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006503002/1
4 years, 7 months ago (2016-05-23 11:40:06 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 12:17:11 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 12:18:06 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6aac5025193119560369c1f3ca099a35f8ea86d
Cr-Commit-Position: refs/heads/master@{#395304}

Powered by Google App Engine
This is Rietveld 408576698