Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2006483002: Clean up doc_ocg.cpp. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix tests #

Patch Set 3 : nits #

Total comments: 2

Patch Set 4 : rebase #

Patch Set 5 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -180 lines) Patch
M core/fpdfdoc/doc_ocg.cpp View 1 2 3 4 3 chunks +146 lines, -155 lines 0 comments Download
M core/fpdfdoc/include/fpdf_doc.h View 2 chunks +14 lines, -21 lines 0 comments Download
M fpdfsdk/fpdfformfill.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M fpdfsdk/fsdk_mgr.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Lei Zhang
4 years, 7 months ago (2016-05-23 16:20:28 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/2006483002/diff/40001/core/fpdfdoc/doc_ocg.cpp File core/fpdfdoc/doc_ocg.cpp (right): https://codereview.chromium.org/2006483002/diff/40001/core/fpdfdoc/doc_ocg.cpp#newcode253 core/fpdfdoc/doc_ocg.cpp:253: if (const CPDF_Dictionary* pDict = pOCGObj->AsDictionary()) nit: maybe ...
4 years, 7 months ago (2016-05-23 16:39:04 UTC) #3
Lei Zhang
https://codereview.chromium.org/2006483002/diff/40001/core/fpdfdoc/doc_ocg.cpp File core/fpdfdoc/doc_ocg.cpp (right): https://codereview.chromium.org/2006483002/diff/40001/core/fpdfdoc/doc_ocg.cpp#newcode253 core/fpdfdoc/doc_ocg.cpp:253: if (const CPDF_Dictionary* pDict = pOCGObj->AsDictionary()) On 2016/05/23 16:39:04, ...
4 years, 7 months ago (2016-05-23 18:29:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006483002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006483002/80001
4 years, 7 months ago (2016-05-23 18:29:24 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 19:28:50 UTC) #9
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/ef4e8878cbcc19cd77f79dd8258d2a981429...

Powered by Google App Engine
This is Rietveld 408576698