Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2006463002:
Scale the location of drag image for high DPI (Closed)
|
Created:
4 years, 7 months ago by oshima Modified:
4 years, 7 months ago Reviewers:
Elliot Glaysher CC:
chromium-reviews, tfarina, dcheng Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionScale the location of drag image for high DPI
Use fixed size for drag widget to avoid recomputed by scaling.
BUG=613829
TEST=DesktopDragDropCleintAura11Test.HighDPI*
Committed: https://crrev.com/099a6b940d41cc6741fc27ce5852d86559f1ff01
Cr-Commit-Position: refs/heads/master@{#395685}
Patch Set 1 : #
Messages
Total messages: 26 (15 generated)
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006463002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Fix dragging in high DPI BUG= ========== to ========== Fix dragging in high DPI BUG=613829 ==========
oshima@chromium.org changed reviewers: + sadrul@chromium.org
Description was changed from ========== Fix dragging in high DPI BUG=613829 ========== to ========== Scale the location of drag image for high DPI BUG=613829 ==========
Patchset #2 (id:20001) has been deleted
Patchset #1 (id:1) has been deleted
Patchset #1 (id:40001) has been deleted
Description was changed from ========== Scale the location of drag image for high DPI BUG=613829 ========== to ========== Scale the location of drag image for high DPI Use fixed size for drag widget to avoid recomputed by scaling. BUG=613829 TEST=DesktopDragDropCleintAura11Test.HighDPI* ==========
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006463002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006463002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
oshima@chromium.org changed reviewers: + erg@chromium.org - sadrul@chromium.org
sending to erg@ who is owner of x11 files.
lgtm
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006463002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006463002/60001
Message was sent while issue was closed.
Description was changed from ========== Scale the location of drag image for high DPI Use fixed size for drag widget to avoid recomputed by scaling. BUG=613829 TEST=DesktopDragDropCleintAura11Test.HighDPI* ========== to ========== Scale the location of drag image for high DPI Use fixed size for drag widget to avoid recomputed by scaling. BUG=613829 TEST=DesktopDragDropCleintAura11Test.HighDPI* ==========
Message was sent while issue was closed.
Committed patchset #1 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Scale the location of drag image for high DPI Use fixed size for drag widget to avoid recomputed by scaling. BUG=613829 TEST=DesktopDragDropCleintAura11Test.HighDPI* ========== to ========== Scale the location of drag image for high DPI Use fixed size for drag widget to avoid recomputed by scaling. BUG=613829 TEST=DesktopDragDropCleintAura11Test.HighDPI* Committed: https://crrev.com/099a6b940d41cc6741fc27ce5852d86559f1ff01 Cr-Commit-Position: refs/heads/master@{#395685} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/099a6b940d41cc6741fc27ce5852d86559f1ff01 Cr-Commit-Position: refs/heads/master@{#395685}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:60001) has been created in https://codereview.chromium.org/2010473006/ by isheriff@chromium.org. The reason for reverting is: Fails MSan Tests on: DesktopDragDropClientAuraX11Test.RejectAfterMouseRelease DesktopDragDropClientAuraX11Test.TargetChanges DesktopDragDropClientAuraX11Test.HighDPI150 DesktopDragDropClientAuraX11Test.TargetDoesNotRespond DesktopDragDropClientAuraX11Test.Basic DesktopDragDropClientAuraX11Test.QueuePosition DesktopDragDropClientAuraX11Test.HighDPI200. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
