Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2006443002: Use factory constructor for list literals (Closed)

Created:
4 years, 7 months ago by sra1
Modified:
4 years, 7 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use factory constructor for list literals The list literal `<int>[1, 2, 3]` was dart.list([1, 2, 3], core.int) now becomes JSArrayOfInt().of([1, 2, 3]) R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/b2ebb32cbdf4ac4c35c537e7711ced5d54b04f1b

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -130 lines) Patch
M lib/runtime/dart_sdk.js View 1 80 chunks +137 lines, -113 lines 0 comments Download
M lib/src/compiler/code_generator.dart View 1 1 chunk +8 lines, -3 lines 0 comments Download
M tool/input_sdk/private/js_array.dart View 1 1 chunk +10 lines, -0 lines 0 comments Download
M tool/sdk_expected_errors.txt View 1 2 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
sra1
4 years, 7 months ago (2016-05-25 19:54:56 UTC) #5
Leaf
lgtm
4 years, 7 months ago (2016-05-25 23:55:24 UTC) #6
sra1
4 years, 7 months ago (2016-05-26 00:41:01 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
b2ebb32cbdf4ac4c35c537e7711ced5d54b04f1b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698