Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 200643002: Presubmit: fix accepted copyright dates. (Closed)

Created:
6 years, 9 months ago by rvargas (doing something else)
Modified:
6 years, 9 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Presubmit: fix accepted copyright dates. 2006-2009/10 was a valid copyright date format before 2011 (when we decided to use only one year, not a range). The current directive with copyright is in fact to not change old copyright dates, so there is no plan to go back and "fix" old files. As such, the presubmit checks should not be complaining about old files. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=257181

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M presubmit_canned_checks.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rvargas (doing something else)
PTAL
6 years, 9 months ago (2014-03-14 18:36:37 UTC) #1
M-A Ruel
lgtm
6 years, 9 months ago (2014-03-14 18:42:52 UTC) #2
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 9 months ago (2014-03-14 19:40:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/200643002/1
6 years, 9 months ago (2014-03-14 19:41:00 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-14 19:43:22 UTC) #5
Message was sent while issue was closed.
Change committed as 257181

Powered by Google App Engine
This is Rietveld 408576698