Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2006423005: Revert of Enable sending frame-specific messages to the correct input router. (Closed)

Created:
4 years, 7 months ago by Charlie Reis
Modified:
4 years, 7 months ago
Reviewers:
wjmaclean
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable sending frame-specific messages to the correct input router. (patchset #1 id:1 of https://codereview.chromium.org/2012933002/ ) Reason for revert: Caused crashes because RFH::GetRenderWidgetHost() returns null unless the frame owns its own widget. See https://crbug.com/614952. Original issue's description: > Enable sending frame-specific messages to the correct input router. > > Presently RenderFrameHostImpl::Send() does not use its own widget's > input router when sending message, meaning messages to subframes could > be sent to the wrong frame. This was discovered while trying to make > InputMsg_SelectRange/InputHostMsg_SelectRange_Ack work properly for > messages sent to an out-of-process iframe. > > BUG=470662 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/7a22bf01ea55475b295e40f5bbfd1add2bc73649 > Cr-Commit-Position: refs/heads/master@{#396044} TBR=wjmaclean@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=470662 Committed: https://crrev.com/6c93d01f53cabcbf405ed29f5345672d7e3455cf Cr-Commit-Position: refs/heads/master@{#396201}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Charlie Reis
Created Revert of Enable sending frame-specific messages to the correct input router.
4 years, 7 months ago (2016-05-26 16:55:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006423005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006423005/1
4 years, 7 months ago (2016-05-26 16:56:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 16:56:47 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 16:58:39 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c93d01f53cabcbf405ed29f5345672d7e3455cf
Cr-Commit-Position: refs/heads/master@{#396201}

Powered by Google App Engine
This is Rietveld 408576698