Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2006423003: [turbofan] Remove the EmptyFrameState caching on JSGraph. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove the EmptyFrameState caching on JSGraph. Caching nodes with mutable inputs is a bad idea and already blew up twice now, so in order to avoid further breakage, let's kill the EmptyFrameState caching on JSGraph completely and only cache the empty state values there. We can remove the hacking from JSTypedLowering completely once we have the PlainPrimitiveToNumber in action. R=jarin@chromium.org Committed: https://crrev.com/dd609a5d3d55bac40cf432ae23b72c82e75bb8bb Cr-Commit-Position: refs/heads/master@{#36511}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -104 lines) Patch
M src/compiler/js-graph.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/compiler/js-graph.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 3 chunks +11 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-js-context-specialization.cc View 1 chunk +0 lines, -75 lines 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 7 months ago (2016-05-25 10:42:32 UTC) #1
Benedikt Meurer
Hey Jaro, The caching is potentially always broken as long as you have mutable inputs. ...
4 years, 7 months ago (2016-05-25 10:43:16 UTC) #2
Jarin
lgtm
4 years, 7 months ago (2016-05-25 10:50:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006423003/1
4 years, 7 months ago (2016-05-25 10:50:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 11:04:49 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 11:05:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd609a5d3d55bac40cf432ae23b72c82e75bb8bb
Cr-Commit-Position: refs/heads/master@{#36511}

Powered by Google App Engine
This is Rietveld 408576698