Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: chrome/browser/task_management/providers/web_contents/web_contents_task_provider.cc

Issue 2006423002: Task Manager: Make double-clicking on an extension do something useful. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tm_selection
Patch Set: Lazily look up the extension. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/task_management/providers/web_contents/subframe_task.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/task_management/providers/web_contents/web_contents_task_provider.cc
diff --git a/chrome/browser/task_management/providers/web_contents/web_contents_task_provider.cc b/chrome/browser/task_management/providers/web_contents/web_contents_task_provider.cc
index db1f81bcf6a442d90ec4d39ae2ea50d039f5f59d..f6862a33f3dd7e1330d7d9d3df792f75de86e2c4 100644
--- a/chrome/browser/task_management/providers/web_contents/web_contents_task_provider.cc
+++ b/chrome/browser/task_management/providers/web_contents/web_contents_task_provider.cc
@@ -230,7 +230,9 @@ void WebContentsEntry::CreateTaskForFrame(RenderFrameHost* render_frame_host) {
new_task = tag->CreateTask();
main_frame_site_instance_ = site_instance;
} else {
- new_task = new SubframeTask(render_frame_host, web_contents());
+ new_task =
+ new SubframeTask(render_frame_host, web_contents(),
+ GetTaskForFrame(web_contents()->GetMainFrame()));
afakhry 2016/05/25 20:07:09 I hope the task of the main frame gets created bef
ncarter (slow) 2016/05/25 20:34:23 Yes; the way we use WebContentsObserver guarantees
}
}
« no previous file with comments | « chrome/browser/task_management/providers/web_contents/subframe_task.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698