Issue 20064006: Rollback Nexus10, ANGLE, and Win7 expectations after r10251 revert.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20064006: Rollback Nexus10, ANGLE, and Win7 expectations after r10251 revert. (Closed)

Created:
7 years, 5 months ago by f(malita)

Modified:
7 years, 5 months ago

Reviewers:
robertphillips, Stephen White

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Rollback Nexus10, ANGLE, and Win7 expectations after r10251 revert. This is a revert of r10252. R=senorblanco@chromium.org Committed: https://code.google.com/p/skia/source/detail?r=10313

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -11 lines)			Patch
M	expectations/gm/base-android-nexus-10/expected-results.json	View	7 chunks	+7 lines, -7 lines	0 comments	Download
M	expectations/gm/base-shuttle-win7-intel-angle/expected-results.json	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	expectations/gm/base-shuttle-win7-intel-float/expected-results.json	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

f(malita)

Committed patchset #1 manually as r10313 (presubmit successful).

7 years, 5 months ago (2013-07-24 15:48:28 UTC) #3

f(malita)

7 years, 5 months ago (2013-07-24 20:30:51 UTC) #4

Message was sent while issue was closed.

On 2013/07/24 15:48:28, Florin Malita wrote:
> Committed patchset #1 manually as r10313 (presubmit successful).

Looks like GMs are still failing for imageblur_gpu.png imagefiltersbase_gpu.png,
so I think this simple revert didn't do it. I guess we need a proper rebaseline?

Expand Messages | Collapse Messages