Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 2006393004: [MIPS] Rename variable mips to mips32 (Closed)

Created:
4 years, 7 months ago by mveljko
Modified:
4 years, 7 months ago
Reviewers:
Mark Mentovai, vapier
CC:
google-breakpad-dev_googlegroups.com, gordana.cmiljanovic_imgtec.com, petar.jovanovic
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[MIPS] Rename variable mips to mips32 Renaming variable mips to mips32 since mips is already defined by the toolchain. BUG=Compile error in Chromium R=mark@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/71a5ee37a5c34b5de383c93a57424040d24a82ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/google_breakpad/processor/microdump.h View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/microdump.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mveljko
On 2016/05/25 08:53:40, mveljko wrote: > mailto:veljko.mihailovic@imgtec.com changed reviewers: > + mailto:mark@chromium.org, mailto:vapier@chromium.org Please take ...
4 years, 7 months ago (2016-05-25 08:53:57 UTC) #3
Mark Mentovai
LGTM, although I find it odd that the toolchain would define “mips.” Are you sure ...
4 years, 7 months ago (2016-05-25 14:03:55 UTC) #4
mveljko
On 2016/05/25 14:03:55, Mark Mentovai wrote: > LGTM, although I find it odd that the ...
4 years, 7 months ago (2016-05-25 14:07:07 UTC) #5
Mark Mentovai
Ugh. I guess it’s like that awful non-underscored i386 macro. LGTM.
4 years, 7 months ago (2016-05-25 14:10:46 UTC) #6
Mark Mentovai
Committed patchset #1 (id:1) manually as 71a5ee37a5c34b5de383c93a57424040d24a82ba (presubmit successful).
4 years, 7 months ago (2016-05-25 14:13:24 UTC) #8
vapier
4 years, 7 months ago (2016-05-25 15:49:55 UTC) #9
Message was sent while issue was closed.
yep, it's exactly like "i386" and "i686".  a bunch of arches do this :/.

Powered by Google App Engine
This is Rietveld 408576698