Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2006363002: Record Physical Web status at Chrome startup (Closed)

Created:
4 years, 7 months ago by cco3
Modified:
4 years, 7 months ago
Reviewers:
nyquist, mattreynolds
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record Physical Web status at Chrome startup BUG=594194 Committed: https://crrev.com/c8aece4cc68d2088887c01911f930292393bcddb Cr-Commit-Position: refs/heads/master@{#396008}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java View 1 3 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
cco3
4 years, 7 months ago (2016-05-24 20:18:18 UTC) #2
mattreynolds
lgtm with nit https://codereview.chromium.org/2006363002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java (right): https://codereview.chromium.org/2006363002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java#newcode58 chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java:58: private static final String CHROME_START = ...
4 years, 7 months ago (2016-05-24 22:09:24 UTC) #3
cco3
nyquist@chromium.org: Please review changes in
4 years, 7 months ago (2016-05-24 22:32:47 UTC) #5
nyquist
lgtm
4 years, 7 months ago (2016-05-25 20:22:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006363002/20001
4 years, 7 months ago (2016-05-25 20:54:00 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-25 22:27:27 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 22:29:07 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c8aece4cc68d2088887c01911f930292393bcddb
Cr-Commit-Position: refs/heads/master@{#396008}

Powered by Google App Engine
This is Rietveld 408576698