Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2006353003: [turbofan] Avoid unnecessary copying of nodes during inlining. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, Michael Starzinger
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Avoid unnecessary copying of nodes during inlining. Previously we first created a temporary graph for the inlinee and then copied over all the nodes to the actual graph. This however introduces unnecessary complexity, and we can instead just create the inlinee inside the target graph. R=jarin@chromium.org Committed: https://crrev.com/a436e3ddafb4efbfce9e90e4f502d06680e06efc Cr-Commit-Position: refs/heads/master@{#36508}

Patch Set 1 #

Patch Set 2 : Inlining when going from bytecode does not work yet. #

Patch Set 3 : Don't use one EmptyFrameState cross functions, that gets mutated during inlining. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -134 lines) Patch
M src/compiler/ast-graph-builder.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 4 chunks +15 lines, -3 lines 0 comments Download
M src/compiler/graph.h View 1 chunk +21 lines, -2 lines 0 comments Download
M src/compiler/js-graph.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M src/compiler/js-graph.cc View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M src/compiler/js-inlining.h View 1 chunk +5 lines, -2 lines 0 comments Download
M src/compiler/js-inlining.cc View 4 chunks +60 lines, -114 lines 0 comments Download
M src/compiler/pipeline.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
A + test/mjsunit/compiler/inline-dead-jscreate.js View 1 2 1 chunk +8 lines, -9 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (7 generated)
Benedikt Meurer
4 years, 7 months ago (2016-05-25 05:17:24 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the inlining cleanup. Please take a look. Thanks, Benedikt
4 years, 7 months ago (2016-05-25 05:21:16 UTC) #2
Jarin
lgtm
4 years, 7 months ago (2016-05-25 06:46:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006353003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006353003/20001
4 years, 7 months ago (2016-05-25 06:46:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/6288) v8_linux_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 7 months ago (2016-05-25 07:24:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006353003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006353003/40001
4 years, 7 months ago (2016-05-25 09:34:35 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-25 10:04:41 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 10:07:11 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a436e3ddafb4efbfce9e90e4f502d06680e06efc
Cr-Commit-Position: refs/heads/master@{#36508}

Powered by Google App Engine
This is Rietveld 408576698