Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2006333004: Fix analyze_dart2js_helpers_test (Closed)

Created:
4 years, 7 months ago by Johnni Winther
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M tests/compiler/dart2js/analyze_dart2js_helpers_test.dart View 5 chunks +12 lines, -3 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
https://codereview.chromium.org/2006333004/diff/1/tests/compiler/dart2js/analyze_dart2js_helpers_test.dart File tests/compiler/dart2js/analyze_dart2js_helpers_test.dart (left): https://codereview.chromium.org/2006333004/diff/1/tests/compiler/dart2js/analyze_dart2js_helpers_test.dart#oldcode108 tests/compiler/dart2js/analyze_dart2js_helpers_test.dart:108: return '$uri'.startsWith('package:compiler/src/helpers/'); With the change to use `compiler.analyzeUri` some ...
4 years, 7 months ago (2016-05-26 12:13:21 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 7 months ago (2016-05-26 22:38:50 UTC) #3
Johnni Winther
4 years, 6 months ago (2016-05-27 08:45:44 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
e25e6206d88b732dac2830dc2474fb8840bd4988 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698