Chromium Code Reviews
DescriptionRemove dead code: builder_path_from_name, builder_path_from_port_name
This is a follow-up to http://crrev.com/2006383003.
Turns out builder_name_from_port_name and builder_name_from_path
aren't use anywhere, (the actual way that the builder names get
changed when getting the Google Storage path is by a function in
webkitpy.common.config.urls:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/config/urls.py&l=40
Since the only test in the unit test was testing build_path_from_name,
I removed the unit test for now, but I think it would be good to re-add
it with a test for builder_name_for_port_name in another CL.
This also removes rebaseline_override_dir and _ports_without_builders (both unused)
Committed: https://crrev.com/f66b53aae8a91a6814150b6971dd4f875370c32c
Cr-Commit-Position: refs/heads/master@{#395997}
Patch Set 1 #Patch Set 2 : Rebased #
Messages
Total messages: 9 (4 generated)
|
|||||||||||||||||||||||||||||||||||||