Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2006333003: Remove dead code: builder_path_from_name, builder_path_from_port_name (Closed)

Created:
4 years, 7 months ago by qyearsley
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke, prasadv
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dead code: builder_path_from_name, builder_path_from_port_name This is a follow-up to http://crrev.com/2006383003. Turns out builder_name_from_port_name and builder_name_from_path aren't use anywhere, (the actual way that the builder names get changed when getting the Google Storage path is by a function in webkitpy.common.config.urls: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/config/urls.py&l=40 Since the only test in the unit test was testing build_path_from_name, I removed the unit test for now, but I think it would be good to re-add it with a test for builder_name_for_port_name in another CL. This also removes rebaseline_override_dir and _ports_without_builders (both unused) Committed: https://crrev.com/f66b53aae8a91a6814150b6971dd4f875370c32c Cr-Commit-Position: refs/heads/master@{#395997}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -66 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/builder_list.py View 1 4 chunks +3 lines, -19 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/builder_list_unittest.py View 1 1 chunk +0 lines, -44 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
qyearsley
4 years, 7 months ago (2016-05-25 17:42:58 UTC) #2
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-25 19:33:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006333003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006333003/20001
4 years, 7 months ago (2016-05-25 20:41:04 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-25 22:01:08 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 22:03:49 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f66b53aae8a91a6814150b6971dd4f875370c32c
Cr-Commit-Position: refs/heads/master@{#395997}

Powered by Google App Engine
This is Rietveld 408576698