Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2006333002: Fixing an unused-variable warning in microdump_writer.cc (Closed)

Created:
4 years, 7 months ago by ivanpe
Modified:
4 years, 7 months ago
CC:
google-breakpad-dev_googlegroups.com, Tobias Sargeant
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixing an unused-variable warning in microdump_writer.cc BUG=https://bugs.chromium.org/p/google-breakpad/issues/detail?id=699 R=mark@chromium.org, primiano@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/79901bb99d5f5bdfc8ed7e422250a9d008b941a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/client/linux/microdump_writer/microdump_writer.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
ivanpe
4 years, 7 months ago (2016-05-24 18:27:38 UTC) #3
Mark Mentovai
LGTM
4 years, 7 months ago (2016-05-24 18:28:29 UTC) #4
Primiano Tucci (use gerrit)
LGTM, +tobiasjs FYI as this came from https://codereview.chromium.org/1796803003/. I wonder how it managed to roll ...
4 years, 7 months ago (2016-05-24 18:30:11 UTC) #5
ivanpe
4 years, 7 months ago (2016-05-24 19:08:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
79901bb99d5f5bdfc8ed7e422250a9d008b941a1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698