LayoutTests/css3/masking/clip-path-animation.html - Issue 200633005: [CSS Shapes] Remove deprecated shapes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/css3/masking/clip-path-animation.html

Issue 200633005: [CSS Shapes] Remove deprecated shapes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase against ToR Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/animations/interpolation/shape-outside-expected.txt ('K') | « LayoutTests/animations/interpolation/webkit-clip-path-interpolation-expected.txt ('k') | LayoutTests/css3/masking/clip-path-animation-expected.txt » ('j') | LayoutTests/fast/shapes/parsing/parsing-shape-inside-expected.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/css3/masking/clip-path-animation.html

diff --git a/LayoutTests/css3/masking/clip-path-animation.html b/LayoutTests/css3/masking/clip-path-animation.html

index 77caf23d249c6e05c0ce7799c1d04c5f93f55ae8..7c0793118c7a70abcd9b47cc8eba05eb8e190e2e 100644

--- a/LayoutTests/css3/masking/clip-path-animation.html

+++ b/LayoutTests/css3/masking/clip-path-animation.html

@@ -11,8 +11,8 @@

display: inline-block;

}

- #rectangle-box {

- -webkit-animation: rectangle-anim 2s linear

+ #inset-box {

+ -webkit-animation: inset-anim 2s linear

}

#circle-box {

@@ -28,9 +28,9 @@

}

- @-webkit-keyframes rectangle-anim {

- from { -webkit-clip-path: rectangle(0%, 0%, 100%, 100%); }

- to { -webkit-clip-path: rectangle(20%, 20%, 60%, 60%); }

+ @-webkit-keyframes inset-anim {

+ from { -webkit-clip-path: inset(0%); }

+ to { -webkit-clip-path: inset(20%); }

}

@-webkit-keyframes circle-anim {

@@ -53,8 +53,8 @@

const expectedValues = [

// [time, element-id, property, expected-value, tolerance]

- [1, "rectangle-box", "webkitClipPath", "rectangle(10%, 10%, 80%, 80%, 0px, 0px)", 0.05],

- [1, "circle-box", "webkitClipPath", "circle(35% at 35% 35%)", 0.05],

+ // [1, "inset-box", "webkitClipPath", "inset(10% 10% 10% 10% round 0px 0px 0px 0px / 0px 0px 0px 0px)", 0.05],

Bem Jones-Bey (adobe) 2014/03/19 21:21:04 Can you put a FIXME saying why this is commented o

+ [1, "circle-box", "webkitClipPath", "circle(35% at 35% 35%)", 0.05],

[1, "ellipse-box", "webkitClipPath", "ellipse(35% 30% at 35% 35%)", 0.05],

[1, "polygon-box", "webkitClipPath", "polygon(10% 10%, 90% 10%, 90% 90%, 10% 90%)", 0.05],

];

@@ -64,7 +64,7 @@

</head>

<body>

-<div class="box" id="rectangle-box"></div>

+<div class="box" id="inset-box"></div>

Bem Jones-Bey (adobe) 2014/03/19 21:21:04 Shouldn't this be commented since the "expected va