Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: ios/web/BUILD.gn

Issue 2006273005: [ios Mojo] Integration test for Mojo WebUI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review comments (GN and GYP) Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/web/ios_web_inttests.gyp » ('j') | ios/web/test/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/BUILD.gn
diff --git a/ios/web/BUILD.gn b/ios/web/BUILD.gn
index e77799d78ff3f3efde6f963328f64581b85f76e4..a31e4369c18375e04b48550c584f6b3ccc59eabd 100644
--- a/ios/web/BUILD.gn
+++ b/ios/web/BUILD.gn
@@ -473,8 +473,13 @@ test("ios_web_inttests") {
":test_support",
":web",
"//base/test:test_support",
+ "//ios/public/provider/web",
+ "//ios/web/test:mojo_bindings",
+ "//ios/web/test:packed_resources",
Eugene But (OOO till 7-30) 2016/05/31 17:26:57 Sylvain, this does not work and resources were not
sdefresne 2016/05/31 18:52:25 [7323:1803:0531/100248:467360551880:ERROR:memory_m
Eugene But (OOO till 7-30) 2016/05/31 23:20:35 D'oh! Sorry about that :)
+ "//ios/web/test:resources",
"//mojo/edk/system",
"//net:test_support",
+ "//services/shell/public/cpp",
"//testing/gtest",
"//ui/base:test_support",
]
@@ -482,6 +487,7 @@ test("ios_web_inttests") {
"browser_state_web_view_partition_inttest.mm",
"public/test/http_server_inttest.mm",
"test/run_all_unittests.cc",
+ "webui/web_ui_mojo_inttest.mm",
]
}
@@ -537,6 +543,6 @@ grit("resources") {
]
grit_flags = [
sdefresne 2016/05/31 18:52:26 I think you should remove this.
Eugene But (OOO till 7-30) 2016/05/31 23:20:35 Done.
"-E",
- "root_out_dir=" + rebase_path(root_out_dir, root_build_dir),
+ "root_gen_dir=" + rebase_path(root_gen_dir, root_build_dir),
]
}
« no previous file with comments | « no previous file | ios/web/ios_web_inttests.gyp » ('j') | ios/web/test/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698