Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2006273004: Change permissions of modules in webkitpy/w3c/ to be non-executable. (Closed)

Created:
4 years, 6 months ago by qyearsley
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke, jsbell, ojan
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change permissions of modules in webkitpy/w3c/ to be non-executable. These files have no particular need to be executable or to have a shebang line; they're imported and used by test_importer, which is used by import-w3c-tests. Committed: https://crrev.com/3a19c8398615a387a7d5d4506c893567dc5aba4e Cr-Commit-Position: refs/heads/master@{#397054}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_parser.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
qyearsley
4 years, 6 months ago (2016-05-26 00:23:18 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006273004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006273004/1
4 years, 6 months ago (2016-05-26 01:00:01 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-26 04:13:22 UTC) #6
commit-bot: I haz the power
Dry run: None
4 years, 6 months ago (2016-05-26 04:13:29 UTC) #7
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-01 00:08:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006273004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006273004/1
4 years, 6 months ago (2016-06-01 03:12:37 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 04:20:46 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 04:22:41 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a19c8398615a387a7d5d4506c893567dc5aba4e
Cr-Commit-Position: refs/heads/master@{#397054}

Powered by Google App Engine
This is Rietveld 408576698