Issue 2006263005: Urgent: disable search API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2006263005: Urgent: disable search API. (Closed)

Created:
4 years, 6 months ago by M-A Ruel

Modified:
4 years, 6 months ago

Reviewers:
Vadim Sh.

CC:
chromium-reviews, infra-reviews+luci-py_chromium.org

Base URL:
git@github.com:luci/luci-py.git@master

Target Ref:
refs/heads/master

Project:
luci-py

Visibility:
Public.

More Reviews

Description

Urgent: disable search API. It is generating OverQuotaError for the past 25 minutes. This is not an essential feature. R=vadimsh@chromium.org BUG=chromium:614811

Patch Set 1 #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -14 lines)			Patch
	M	appengine/swarming/server/task_scheduler.py	View		3 chunks	+14 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

M-A Ruel

This breaks two test case that test the search functionality. I knew we should depend ...

4 years, 6 months ago (2016-05-25 20:48:04 UTC) #1

Vadim Sh.

4 years, 6 months ago (2016-05-25 21:28:24 UTC) #3

I'm sorry... Using Search API to do searches seemed like a good idea at the
time.

I'm pretty sure whatever we slap together on top of the datastore will be slower
and more expensive.

If it's not an essential feature, maybe we can catch exceptions, log and ignore
them instead of killing the request.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages