Issue 2006263003: Version 5.0.71.53 (cherry-pick)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2006263003: Version 5.0.71.53 (cherry-pick) (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer

Modified:
4 years, 7 months ago

Reviewers:
Jarin

CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr., ulan

Base URL:
https://chromium.googlesource.com/v8/v8.git@5.0

Target Ref:
refs/pending/branch-heads/5.0

Project:
v8

Visibility:
Public.

Version 5.0.71.53 (cherry-pick) Merged cc71837fdae85a2b92db65d29146b2ab89ba77da [builtins] Migrate String.fromCharCode to C++. R=jarin@chromium.org BUG=chromium:609831 LOG=N Committed: https://chromium.googlesource.com/v8/v8/+/72bfbdcf49c653be2ed3a8ef53180f586b168bb2

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+97 lines, -53 lines)			Patch
M	include/v8-version.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/bootstrapper.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/builtins.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/builtins.cc	View	1 chunk	+68 lines, -0 lines	0 comments	Download
M	src/js/string.js	View	2 chunks	+0 lines, -13 lines	0 comments	Download
M	test/cctest/test-strings.cc	View	1 chunk	+22 lines, -0 lines	0 comments	Download
D	test/mjsunit/regress/regress-seqstrsetchar-ex2.js	View	1 chunk	+0 lines, -34 lines	0 comments	Download
M	test/mjsunit/string-fromcharcode.js	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 4 (1 generated)

Benedikt Meurer

4 years, 7 months ago (2016-05-25 05:01:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
72bfbdcf49c653be2ed3a8ef53180f586b168bb2.