ui/events/gesture_detection/gesture_config_helper_android.cc - Issue 200623003: Adopt "QuickScale" double-tap drag zoom code in the GestureProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/gesture_detection/gesture_config_helper_android.cc

Issue 200623003: Adopt "QuickScale" double-tap drag zoom code in the GestureProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/input/web_input_event_traits.cc ('K') | « content/common/input/web_input_event_traits.cc ('k') | ui/events/gesture_detection/gesture_config_helper_aura.cc » ('j') | ui/events/gesture_detection/gesture_provider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/events/gesture_detection/gesture_config_helper_android.cc

diff --git a/ui/events/gesture_detection/gesture_config_helper_android.cc b/ui/events/gesture_detection/gesture_config_helper_android.cc

index db460683491bbb1c573c1cbe8dec531d60f62256..96aa7a6ad13fb14afab552806a934c7e16e7ab11 100644

--- a/ui/events/gesture_detection/gesture_config_helper_android.cc

+++ b/ui/events/gesture_detection/gesture_config_helper_android.cc

@@ -37,9 +37,7 @@ ScaleGestureDetector::Config DefaultScaleGestureDetectorConfig() {

ScaleGestureDetector::Config config;

config.gesture_detector_config = DefaultGestureDetectorConfig();

- // TODO(jdduke): Enable "quick scale" on the ScaleGestureDetector, and remove

- // corresponding double tap drag zoom code from GestureProvider, crbug/331092.

- config.quick_scale_enabled = false;

+ config.quick_scale_enabled = true;

config.min_scaling_touch_major =

ViewConfiguration::GetMinScalingTouchMajorInPixels();

config.min_scaling_span = ViewConfiguration::GetMinScalingSpanInPixels();