Reland of Memory Infra: Replace memory_health_plan with top_10_mobile

Reland of Memory Infra: Replace memory_health_plan with top_10_mobile

Replace memory.memory_health_plan with the memory.top_10_mobile
benchmark. (But the old name is maintained to give a chance for bots
to be updated.)

This keeps the story to provide foreground/background measurements,
but swaps the page set to use top_10_mobile.

New recordings are provided.

Perf sheriffs warning: this is very likely to cause measurements in
corresponding memory infra metrics to shift.

BUG=606361
TBR=sullivan@chromium.org,primiano@chromium.org,petrcermak@chromium.org

Committed: https://crrev.com/1ac6c6b7aa6b67f8b2a8df8af2c3c347aafb0f0b
Cr-Commit-Position: refs/heads/master@{#396157}

[perezju, 2016-05-26 08:35:16]

Description was changed from

==========
Reland of Memory Infra: Replace memory_health_plan with top_10_mobile

Replace memory.memory_health_plan with the memory.top_10_mobile
benchmark. (But the old name is maintained to give a chance for bots
to be updated.)

This keeps the story to provide foreground/background measurements,
but swaps the page set to use top_10_mobile.

New recordings are provided.

Perf sheriffs warning: this is very likely to cause measurements in
corresponding memory infra metrics to shift.

BUG=606361
==========

to

==========
Reland of Memory Infra: Replace memory_health_plan with top_10_mobile

Replace memory.memory_health_plan with the memory.top_10_mobile
benchmark. (But the old name is maintained to give a chance for bots
to be updated.)

This keeps the story to provide foreground/background measurements,
but swaps the page set to use top_10_mobile.

New recordings are provided.

Perf sheriffs warning: this is very likely to cause measurements in
corresponding memory infra metrics to shift.

BUG=606361
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

[perezju, 2016-05-26 08:46:50]

perezju@chromium.org changed reviewers:
+ petrcermak@chromium.org, primiano@chromium.org, sullivan@chromium.org

[perezju, 2016-05-26 08:46:51]

I've doubled checked that `tools/perf/run_benchmark list --browser
android-chrome` lists as enabled:

- memory.top_10_mobile
- memory.top_10_mobile_tbmv2

and disabled:

- memory.dual_browser_test

However bots explicitly requesting to run memory.dual_browser_test can still do
so without breaking.

[perezju, 2016-05-26 09:02:02]

On 2016/05/26 08:46:51, perezju wrote:
> I've doubled checked that `tools/perf/run_benchmark list --browser
> android-chrome` lists as enabled:
> 
> - memory.top_10_mobile
> - memory.top_10_mobile_tbmv2
> 
> and disabled:
> 
> - memory.dual_browser_test
> 
> However bots explicitly requesting to run memory.dual_browser_test can still
do
> so without breaking.

s/memory.dual_browser_test/memory.memory_health_plan/ -- copy/pasted the wrong
line :P

[perezju, 2016-05-26 09:49:37]

Description was changed from

==========
Reland of Memory Infra: Replace memory_health_plan with top_10_mobile

Replace memory.memory_health_plan with the memory.top_10_mobile
benchmark. (But the old name is maintained to give a chance for bots
to be updated.)

This keeps the story to provide foreground/background measurements,
but swaps the page set to use top_10_mobile.

New recordings are provided.

Perf sheriffs warning: this is very likely to cause measurements in
corresponding memory infra metrics to shift.

BUG=606361
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
Reland of Memory Infra: Replace memory_health_plan with top_10_mobile

Replace memory.memory_health_plan with the memory.top_10_mobile
benchmark. (But the old name is maintained to give a chance for bots
to be updated.)

This keeps the story to provide foreground/background measurements,
but swaps the page set to use top_10_mobile.

New recordings are provided.

Perf sheriffs warning: this is very likely to cause measurements in
corresponding memory infra metrics to shift.

BUG=606361
TBR=sullivan@chromium.org,primiano@chromium.org,petrcermak@chromium.org
==========

[perezju, 2016-05-26 09:49:45]

The CQ bit was checked by perezju@chromium.org

[commit-bot: I haz the power, 2016-05-26 09:50:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2006223008/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2006223008/20001

[petrcermak, 2016-05-26 09:51:23]

LGTM with 2 nits (sorry).

Thanks,
Petr

https://codereview.chromium.org/2006223008/diff/20001/tools/perf/benchmarks/m...
File tools/perf/benchmarks/memory_infra.py (right):

https://codereview.chromium.org/2006223008/diff/20001/tools/perf/benchmarks/m...
tools/perf/benchmarks/memory_infra.py:85: #TODO(perezju): Remove when all bots
are updated to the new benchmark name.
supernit: Missing space between '#' and 'TODO' O:-)

https://codereview.chromium.org/2006223008/diff/20001/tools/perf/benchmarks/m...
tools/perf/benchmarks/memory_infra.py:88: """Alias of memory.top_10_mobile.
(Deprecated)"""
supernit: I would put the period after the closing parenthesis (probably just a
matter of personal taste).

[perezju, 2016-05-26 09:58:56]

On 2016/05/26 09:51:23, petrcermak wrote:
> LGTM with 2 nits (sorry).
> 
> Thanks,
> Petr
> 
>
https://codereview.chromium.org/2006223008/diff/20001/tools/perf/benchmarks/m...
> File tools/perf/benchmarks/memory_infra.py (right):
> 
>
https://codereview.chromium.org/2006223008/diff/20001/tools/perf/benchmarks/m...
> tools/perf/benchmarks/memory_infra.py:85: #TODO(perezju): Remove when all bots
> are updated to the new benchmark name.
> supernit: Missing space between '#' and 'TODO' O:-)
> 
>
https://codereview.chromium.org/2006223008/diff/20001/tools/perf/benchmarks/m...
> tools/perf/benchmarks/memory_infra.py:88: """Alias of memory.top_10_mobile.
> (Deprecated)"""
> supernit: I would put the period after the closing parenthesis (probably just
a
> matter of personal taste).

If all goes well I'll delete this code tomorrow. So hope you don't mind if I
skip this nits. :)

[petrcermak, 2016-05-26 10:08:32]

On 2016/05/26 09:58:56, perezju wrote:
> On 2016/05/26 09:51:23, petrcermak wrote:
> > LGTM with 2 nits (sorry).
> > 
> > Thanks,
> > Petr
> > 
> >
>
https://codereview.chromium.org/2006223008/diff/20001/tools/perf/benchmarks/m...
> > File tools/perf/benchmarks/memory_infra.py (right):
> > 
> >
>
https://codereview.chromium.org/2006223008/diff/20001/tools/perf/benchmarks/m...
> > tools/perf/benchmarks/memory_infra.py:85: #TODO(perezju): Remove when all
bots
> > are updated to the new benchmark name.
> > supernit: Missing space between '#' and 'TODO' O:-)
> > 
> >
>
https://codereview.chromium.org/2006223008/diff/20001/tools/perf/benchmarks/m...
> > tools/perf/benchmarks/memory_infra.py:88: """Alias of memory.top_10_mobile.
> > (Deprecated)"""
> > supernit: I would put the period after the closing parenthesis (probably
just
> a
> > matter of personal taste).
> 
> If all goes well I'll delete this code tomorrow. So hope you don't mind if I
> skip this nits. :)

That is of course fine :-)

Thanks,
Petr

[commit-bot: I haz the power, 2016-05-26 11:02:50]

Description was changed from

==========
Reland of Memory Infra: Replace memory_health_plan with top_10_mobile

Replace memory.memory_health_plan with the memory.top_10_mobile
benchmark. (But the old name is maintained to give a chance for bots
to be updated.)

This keeps the story to provide foreground/background measurements,
but swaps the page set to use top_10_mobile.

New recordings are provided.

Perf sheriffs warning: this is very likely to cause measurements in
corresponding memory infra metrics to shift.

BUG=606361
TBR=sullivan@chromium.org,primiano@chromium.org,petrcermak@chromium.org
==========

to

==========
Reland of Memory Infra: Replace memory_health_plan with top_10_mobile

Replace memory.memory_health_plan with the memory.top_10_mobile
benchmark. (But the old name is maintained to give a chance for bots
to be updated.)

This keeps the story to provide foreground/background measurements,
but swaps the page set to use top_10_mobile.

New recordings are provided.

Perf sheriffs warning: this is very likely to cause measurements in
corresponding memory infra metrics to shift.

BUG=606361
TBR=sullivan@chromium.org,primiano@chromium.org,petrcermak@chromium.org
==========

[commit-bot: I haz the power, 2016-05-26 11:02:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-26 11:03:51]

Description was changed from

==========
Reland of Memory Infra: Replace memory_health_plan with top_10_mobile

Replace memory.memory_health_plan with the memory.top_10_mobile
benchmark. (But the old name is maintained to give a chance for bots
to be updated.)

This keeps the story to provide foreground/background measurements,
but swaps the page set to use top_10_mobile.

New recordings are provided.

Perf sheriffs warning: this is very likely to cause measurements in
corresponding memory infra metrics to shift.

BUG=606361
TBR=sullivan@chromium.org,primiano@chromium.org,petrcermak@chromium.org
==========

to

==========
Reland of Memory Infra: Replace memory_health_plan with top_10_mobile

Replace memory.memory_health_plan with the memory.top_10_mobile
benchmark. (But the old name is maintained to give a chance for bots
to be updated.)

This keeps the story to provide foreground/background measurements,
but swaps the page set to use top_10_mobile.

New recordings are provided.

Perf sheriffs warning: this is very likely to cause measurements in
corresponding memory infra metrics to shift.

BUG=606361
TBR=sullivan@chromium.org,primiano@chromium.org,petrcermak@chromium.org

Committed: https://crrev.com/1ac6c6b7aa6b67f8b2a8df8af2c3c347aafb0f0b
Cr-Commit-Position: refs/heads/master@{#396157}
==========

[commit-bot: I haz the power, 2016-05-26 11:03:52]

Patchset 2 (id:??) landed as
https://crrev.com/1ac6c6b7aa6b67f8b2a8df8af2c3c347aafb0f0b
Cr-Commit-Position: refs/heads/master@{#396157}