Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2006223006: Enable MD for Chrome on Windows. (Closed)

Created:
4 years, 7 months ago by Peter Kasting
Modified:
4 years, 6 months ago
Reviewers:
tdanderson, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable MD for Chrome on Windows. This enables MD for all remaining platforms since it's already on for Linux, Mac, and Chrome OS. I'm not sure what the effects on iOS and Android will be; I'm hoping they don't even use this file, or if they do, and there are problems, that the trybots will show them. BUG=590285 TEST=none Committed: https://crrev.com/2676e97c1a42b7898fbc09176ab94b59bf1c421d Cr-Commit-Position: refs/heads/master@{#396304}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M ui/base/material_design/material_design_controller.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Peter Kasting
tdanderson: Do you know if this is likely to affect Android/iOS or in general if ...
4 years, 7 months ago (2016-05-26 05:53:14 UTC) #2
tdanderson
On 2016/05/26 05:53:14, Peter Kasting wrote: > tdanderson: Do you know if this is likely ...
4 years, 7 months ago (2016-05-26 15:08:21 UTC) #3
sky
LGTM
4 years, 7 months ago (2016-05-26 16:16:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006223006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006223006/1
4 years, 6 months ago (2016-05-26 22:35:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-26 22:40:31 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-05-26 22:43:24 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2676e97c1a42b7898fbc09176ab94b59bf1c421d
Cr-Commit-Position: refs/heads/master@{#396304}

Powered by Google App Engine
This is Rietveld 408576698