Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: gni/v8.gni

Issue 2006213002: [gn] Fix setting v8_target_arch default (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gni/v8.gni
diff --git a/gni/v8.gni b/gni/v8.gni
index 81fcfbfa7b0e3d5cf1dc3a2a9da4b7b795bd16c8..6a24219c34ea5d8bd449308840ee5af9d40ad421 100644
--- a/gni/v8.gni
+++ b/gni/v8.gni
@@ -2,8 +2,21 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import("//build/config/sanitizers/sanitizers.gni")
+
declare_args() {
# V8 generates code for this architecture. If v8_target_arch differs from
# target_cpu, a simulator will be run.
v8_target_arch = ""
}
+
+if (v8_target_arch == "") {
+ if (is_msan) {
+ # Running the V8-generated code on an ARM simulator is a powerful hack that
+ # allows the tool to see the memory accesses from JITted code. Without this
+ # flag, JS code causes false positive reports from MSan.
+ v8_target_arch = "arm64"
+ } else {
+ v8_target_arch = target_cpu
+ }
+}
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698