Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Side by Side Diff: gni/v8.gni

Issue 2006213002: [gn] Fix setting v8_target_arch default (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 the V8 project authors. All rights reserved. 1 # Copyright 2016 the V8 project authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/sanitizers/sanitizers.gni")
6
5 declare_args() { 7 declare_args() {
6 # V8 generates code for this architecture. If v8_target_arch differs from 8 # V8 generates code for this architecture. If v8_target_arch differs from
7 # target_cpu, a simulator will be run. 9 # target_cpu, a simulator will be run.
8 v8_target_arch = "" 10 v8_target_arch = ""
9 } 11 }
12
13 if (v8_target_arch == "") {
14 if (is_msan) {
15 # Running the V8-generated code on an ARM simulator is a powerful hack that
16 # allows the tool to see the memory accesses from JITted code. Without this
17 # flag, JS code causes false positive reports from MSan.
18 v8_target_arch = "arm64"
19 } else {
20 v8_target_arch = target_cpu
21 }
22 }
OLDNEW
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698