Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2006203002: Fix that NewTabPage.Snippets.CardShown was recorded too early/often. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: A minor polish Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 4141deb8256b4458b5d841a2626515ac21791091..2c690309dc0dccbcbf4ac404b40ea91d98eb90ba 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -33942,9 +33942,17 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="NewTabPage.Snippets.CardShown">
<owner>knn@chromium.org</owner>
<summary>
- Android: The position of the snippets card that is shown on the NTP.
- Depending on the device screen size only some of the cards will be shown
- unless the users scrolls through.
+ Android: The position of the snippets card that is shown on the NTP. Each
+ snippet (its position) is recorded whenever at least 1/3 of it height
+ becomes visible by scrolling through the NTP. Each snippet is recorded at
+ most once for a given instance of NTP and a given data set of snippets that
+ is shown. We track the position the snippet had in the list when NTP was
+ loaded. This tracked position is thus different from the position observed
+ by the user whenever before scrolling down to the given snippet, the user
+ discards some snippets in the top of the list. Previously (in the code
+ before 2016/05/27), this histogram was recorded each time a snippet became
+ visible (e.g. by scrolling up and down) at least by 1px; the first snippet
+ was thus recorded even without scrolling down.
</summary>
</histogram>
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698