tools/metrics/histograms/histograms.xml - Issue 2006203002: Fix that NewTabPage.Snippets.CardShown was recorded too early/often.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2006203002: Fix that NewTabPage.Snippets.CardShown was recorded too early/often. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: After code review #2 Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 391242f244846eb38985d9e8a0799f8e83157fcf..3bc86e4043384707ba4780dc5ae293425c799afa 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -33693,9 +33693,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<owner>knn@chromium.org</owner>

- Android: The position of the snippets card that is shown on the NTP.

- Depending on the device screen size only some of the cards will be shown

- unless the users scrolls through.

+ Android: The position of the snippets card that is shown on the NTP. Each

+ snippet (its position) is recorded whenever at least 1/3 of it height

+ becomes visible by scrolling through the NTP. Each snippet is recorded at

+ most once for a given instance of NTP and a given data set of snippets that

+ is shown. We track the position the snippet had in the list when NTP was

Alexei Svitkine (slow) 2016/05/25 20:23:08 Nit: Extra space after .

jkrcal 2016/05/26 21:48:49 Done.

+ loaded. This tracked position is thus different from the position observed

Alexei Svitkine (slow) 2016/05/25 20:23:08 Nit: Extra space after thus.

jkrcal 2016/05/26 21:48:49 Done.

+ by the user whenever before scrolling down to the given snippet, the user

+ discards some snippets in the top of the list.

Alexei Svitkine (slow) 2016/05/25 20:23:08 Maybe worth mentioning that previously it was reco

jkrcal 2016/05/26 21:48:49 Done.

</summary>

</histogram>