Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: src/heap/spaces.h

Issue 2006183003: Revert of [heap] Fine-grained JSArrayBuffer tracking (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/scavenger.cc ('k') | src/heap/spaces.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/spaces.h
diff --git a/src/heap/spaces.h b/src/heap/spaces.h
index e7c309e22739d8014be203ec871d0c6475e21e0c..aa30e7da3b438102f3b7980b85f6e4e93ea116e0 100644
--- a/src/heap/spaces.h
+++ b/src/heap/spaces.h
@@ -14,7 +14,6 @@
#include "src/base/platform/mutex.h"
#include "src/flags.h"
#include "src/hashmap.h"
-#include "src/heap/array-buffer-tracker.h"
#include "src/list.h"
#include "src/objects.h"
#include "src/utils.h"
@@ -524,8 +523,7 @@
+ kPointerSize // AtomicValue next_chunk_
+ kPointerSize // AtomicValue prev_chunk_
// FreeListCategory categories_[kNumberOfCategories]
- + FreeListCategory::kSize * kNumberOfCategories +
- kPointerSize; // LocalArrayBufferTracker tracker_
+ + FreeListCategory::kSize * kNumberOfCategories;
// We add some more space to the computed header size to amount for missing
// alignment requirements in our computation.
@@ -826,8 +824,6 @@
FreeListCategory categories_[kNumberOfCategories];
- LocalArrayBufferTracker* local_tracker_;
-
private:
void InitializeReservedMemory() { reservation_.Reset(); }
@@ -956,40 +952,6 @@
intptr_t available_in_free_list() { return available_in_free_list_.Value(); }
void add_available_in_free_list(intptr_t available) {
available_in_free_list_.Increment(available);
- }
-
- LocalArrayBufferTracker* local_tracker() {
- if (local_tracker_ == nullptr) {
- local_tracker_ = new LocalArrayBufferTracker(heap_);
- }
- return local_tracker_;
- }
-
- void FreeDeadArrayBuffers() {
- if (local_tracker_ != nullptr) {
- local_tracker_->FreeDead();
- if (local_tracker_->IsEmpty()) {
- delete local_tracker_;
- local_tracker_ = nullptr;
- }
- }
- }
-
- template <LocalArrayBufferTracker::LivenessIndicator liveness_indicator>
- void ScanAndFreeDeadArrayBuffers() {
- if (local_tracker_ != nullptr) {
- local_tracker_->ScanAndFreeDead<liveness_indicator>();
- if (local_tracker_->IsEmpty()) {
- delete local_tracker_;
- local_tracker_ = nullptr;
- }
- }
- }
-
- void ResetTracker() {
- if (local_tracker_ != nullptr) {
- local_tracker_->Reset();
- }
}
#ifdef DEBUG
@@ -2333,16 +2295,6 @@
inline void UnlinkFreeListCategories(Page* page);
inline intptr_t RelinkFreeListCategories(Page* page);
- // Callback signature:
- // void Callback(Page*);
- template <typename Callback>
- void ForAllPages(Callback callback) {
- PageIterator it(this);
- while (it.has_next()) {
- callback(it.next());
- }
- }
-
protected:
// PagedSpaces that should be included in snapshots have different, i.e.,
// smaller, initial pages.
« no previous file with comments | « src/heap/scavenger.cc ('k') | src/heap/spaces.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698