Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2006183003: Revert of [heap] Fine-grained JSArrayBuffer tracking (Closed)

Created:
4 years, 7 months ago by Michael Lippautz
Modified:
4 years, 7 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Fine-grained JSArrayBuffer tracking (patchset #19 id:770001 of https://codereview.chromium.org/1964023002/ ) Reason for revert: Revert it. Original issue's description: > [heap] Fine-grained JSArrayBuffer tracking > > Track based on JSArrayBuffer addresses instead of the attached backing store. > This way we can later on iterate buffers on a single page. The reland also > switches to a page-based implementation where a page contains the set of its > contained (live and dead) buffers. > > Details of tracking: > - Scavenge: New space pages are processes in bulk on the main thread > - MC: Unswept pages are processed in bulk in parallel. All other pages > are processed by the sweeper concurrently. > > BUG=chromium:611688 > LOG=N > CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg,v8_linux64_tsan_rel,v8_mac64_asan_rel > > Committed: https://crrev.com/b2d8bfc7931eef49d527605ba485950dea41cde3 > Cr-Commit-Position: refs/heads/master@{#36437} TBR=hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:611688 Committed: https://crrev.com/d2dff0320b75bf6054e46c379b192619d4884caf Cr-Commit-Position: refs/heads/master@{#36461}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -514 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/array-buffer-tracker.h View 1 chunk +38 lines, -82 lines 0 comments Download
M src/heap/array-buffer-tracker.cc View 2 chunks +94 lines, -104 lines 0 comments Download
D src/heap/array-buffer-tracker-inl.h View 1 chunk +0 lines, -74 lines 0 comments Download
M src/heap/heap.h View 2 chunks +0 lines, -12 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/mark-compact.cc View 8 chunks +18 lines, -15 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap/scavenger.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/heap/spaces.h View 5 chunks +1 line, -49 lines 0 comments Download
M src/heap/spaces.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M src/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/heap/heap-utils.h View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/heap/heap-utils.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D test/cctest/heap/test-array-buffer-tracker.cc View 1 chunk +0 lines, -145 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Lippautz
Created Revert of [heap] Fine-grained JSArrayBuffer tracking
4 years, 7 months ago (2016-05-24 07:21:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006183003/1
4 years, 7 months ago (2016-05-24 07:21:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 07:21:23 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 07:22:09 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2dff0320b75bf6054e46c379b192619d4884caf
Cr-Commit-Position: refs/heads/master@{#36461}

Powered by Google App Engine
This is Rietveld 408576698