Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2006173002: Flip Linux bots on chromium.lkgr to GN. (Closed)

Created:
4 years, 7 months ago by Dirk Pranke
Modified:
4 years, 6 months ago
Reviewers:
brettw, inferno
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@flip_linux_memory_3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip Linux bots on chromium.lkgr to GN. R=brettw@chromium.org, inferno@chromium.org BUG=605732 Committed: https://crrev.com/6864dbb0407a47f697901f70105d2c2c829c08bc Cr-Commit-Position: refs/heads/master@{#398038}

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : merge, split GN changes out into a different CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -47 lines) Patch
M tools/mb/mb_config.pyl View 1 10 chunks +47 lines, -47 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (7 generated)
Dirk Pranke
4 years, 6 months ago (2016-06-02 00:18:04 UTC) #2
Dirk Pranke
4 years, 6 months ago (2016-06-02 00:19:09 UTC) #4
Dirk Pranke
We don't really have any tryservers for these bots, so we're just going to have ...
4 years, 6 months ago (2016-06-02 00:19:28 UTC) #5
inferno
lgtm
4 years, 6 months ago (2016-06-02 01:21:37 UTC) #6
brettw
lgtm
4 years, 6 months ago (2016-06-02 23:57:33 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006173002/40001
4 years, 6 months ago (2016-06-06 03:09:04 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/82244)
4 years, 6 months ago (2016-06-06 04:22:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006173002/40001
4 years, 6 months ago (2016-06-06 15:38:40 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-06 16:03:29 UTC) #15
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/6864dbb0407a47f697901f70105d2c2c829c08bc Cr-Commit-Position: refs/heads/master@{#398038}
4 years, 6 months ago (2016-06-06 16:06:00 UTC) #17
Nico
4 years, 6 months ago (2016-06-09 15:05:25 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2054843002/ by thakis@chromium.org.

The reason for reverting is: This had no effect: The LKGR waterfall used to be
not on recipes, and mb wasn't hooked up right and in gn mode wrote its output to
out/None (and runhooks still ran gyp, so gyp's ninja files were always used).

I've now switched most of the bots to recipes, and now gn does have an effect,
and all the bots now fail to build 'cause they build "chromium_builder_asan", a
target that doesn't exist in the gn build.

Reverting to get back to a working state. I'll look at fixing and will hopefully
reland this soon..

Powered by Google App Engine
This is Rietveld 408576698