Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2006163003: Flip nacl sdk bots to use MB to generate the build files. (Closed)

Created:
4 years, 7 months ago by Dirk Pranke
Modified:
4 years, 6 months ago
Reviewers:
bradnelson
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Flip nacl sdk bots to use MB to generate the build files. The days of running GYP on Linux are almost at an end ... R=bradnelson@chromium.org BUG= Committed: https://chromium.googlesource.com/chromium/tools/build/+/f73a02cf030d9a5ad4b08fe099fd1a822ed4d6ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -0 lines) Patch
M scripts/slave/recipes/nacl/sdk.py View 1 chunk +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/nacl/sdk.expected/basic.json View 2 chunks +22 lines, -0 lines 0 comments Download
M scripts/slave/recipes/nacl/sdk_build.py View 1 chunk +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/nacl/sdk_build.expected/basic.json View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Dirk Pranke
This CL depends on having https://codereview.chromium.org/2001133003/ land first.
4 years, 7 months ago (2016-05-24 02:17:07 UTC) #1
bradnelson
lgtm
4 years, 7 months ago (2016-05-24 22:26:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006163003/1
4 years, 6 months ago (2016-05-31 19:10:58 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 19:14:58 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/f73a02cf030d9a5ad4b0...

Powered by Google App Engine
This is Rietveld 408576698