Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2006143011: Remove first check random delay on older devices (Closed)

Created:
4 years, 7 months ago by Greg Levin
Modified:
4 years, 5 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove first check random delay on older devices BUG=598841 TEST=Not easily testable, as this CL removes code that is no longer active after a first Quirks server check; we expect nearly all devices should have made a server check as of M-54, if they're ever going to. Committed: https://crrev.com/0bbe13103a5a5ce3940a529d986f68ded2e19ac6 Cr-Commit-Position: refs/heads/master@{#404587}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove obsolete TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -80 lines) Patch
M ash/display/display_color_manager_chromeos_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/display/quirks_manager_delegate_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/display/quirks_manager_delegate_impl.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M components/quirks/quirks_manager.h View 3 chunks +0 lines, -17 lines 0 comments Download
M components/quirks/quirks_manager.cc View 1 4 chunks +1 line, -42 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Greg Levin
Removing random 0-30 delay for first server contact. This was to spread out initial server ...
4 years, 5 months ago (2016-07-08 23:18:42 UTC) #2
oshima
lgtm
4 years, 5 months ago (2016-07-09 00:31:17 UTC) #3
Greg Levin
https://codereview.chromium.org/2006143011/diff/1/components/quirks/quirks_manager.cc File components/quirks/quirks_manager.cc (right): https://codereview.chromium.org/2006143011/diff/1/components/quirks/quirks_manager.cc#newcode50 components/quirks/quirks_manager.cc:50: // TODO(glevin): Awaiting final decision on how to handle ...
4 years, 5 months ago (2016-07-10 15:30:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2006143011/20001
4 years, 5 months ago (2016-07-10 15:31:19 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-11 01:15:15 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 01:19:27 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0bbe13103a5a5ce3940a529d986f68ded2e19ac6
Cr-Commit-Position: refs/heads/master@{#404587}

Powered by Google App Engine
This is Rietveld 408576698