Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2006143006: Revert of Pass SequencedTaskRunner to PowerSaveBlocker for ui/file operations (Closed)

Created:
4 years, 7 months ago by hajimehoshi
Modified:
4 years, 7 months ago
CC:
chromium-reviews, asanka, extensions-reviews_chromium.org, jam, imcheng+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, loading-reviews_chromium.org, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org, Sergey Ulanov
Base URL:
https://chromium.googlesource.com/chromium/src.git@device-power-save-blocker
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Pass SequencedTaskRunner to PowerSaveBlocker for ui/file operations (patchset #13 id:240001 of https://codereview.chromium.org/1991593002/ ) Reason for revert: This causes flaky test failures (e.g. https://build.chromium.org/p/chromium.gpu/builders/Linux%20Release%20%28NVIDIA%29/builds/78794) Original issue's description: > Pass SequencedTaskRunner to PowerSaveBlocker for ui/file operations > > Beginning of moving PowerSaveBlocker to //device/power_save_blocker. > > power_save_blocker_factory is a wrapper to pass down the required > SequencedTaskRunners. It will stay in content when the rest of the > power_save_blocker files move to //device. > > BUG=612337, 257943, 612563 > > Committed: https://crrev.com/11c0c210570c67f7b32ebc706102c9e8833cc9a1 > Cr-Commit-Position: refs/heads/master@{#395727} TBR=hashimoto@chromium.org,nick@chromium.org,asargent@chromium.org,tommi@chromium.org,scottmg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=612337, 257943, 612563 Committed: https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf Cr-Commit-Position: refs/heads/master@{#395840}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -266 lines) Patch
M chrome/browser/media/cast_transport_host_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/drive/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/drive/drive_uploader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/DEPS View 2 chunks +2 lines, -10 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/download/download_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/download/download_request_core.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/loader/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/power_save_block_resource_throttle.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/media/capture/aura_window_capture_machine.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/media/media_web_contents_observer.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M content/browser/media/webrtc/webrtc_internals.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/power_save_blocker_android.cc View 6 chunks +14 lines, -22 lines 0 comments Download
M content/browser/power_save_blocker_chromeos.cc View 4 chunks +13 lines, -24 lines 0 comments Download
D content/browser/power_save_blocker_factory.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M content/browser/power_save_blocker_impl.h View 2 chunks +3 lines, -9 lines 0 comments Download
M content/browser/power_save_blocker_impl.cc View 1 chunk +7 lines, -10 lines 0 comments Download
M content/browser/power_save_blocker_mac.cc View 1 chunk +4 lines, -9 lines 0 comments Download
M content/browser/power_save_blocker_ozone.cc View 1 chunk +5 lines, -9 lines 0 comments Download
M content/browser/power_save_blocker_win.cc View 5 chunks +17 lines, -24 lines 0 comments Download
M content/browser/power_save_blocker_x11.cc View 16 chunks +40 lines, -55 lines 0 comments Download
M content/browser/wake_lock/wake_lock_service_context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/browser/power_save_blocker.h View 2 chunks +2 lines, -6 lines 0 comments Download
D content/public/browser/power_save_blocker_factory.h View 1 chunk +0 lines, -25 lines 0 comments Download
M extensions/browser/api/power/power_api.cc View 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
hajimehoshi
Created Revert of Pass SequencedTaskRunner to PowerSaveBlocker for ui/file operations
4 years, 7 months ago (2016-05-25 09:34:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006143006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006143006/1
4 years, 7 months ago (2016-05-25 09:34:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 09:35:55 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf Cr-Commit-Position: refs/heads/master@{#395840}
4 years, 7 months ago (2016-05-25 09:37:36 UTC) #5
scottmg
4 years, 7 months ago (2016-05-25 16:32:20 UTC) #6
Message was sent while issue was closed.
On 2016/05/25 09:37:36, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/da0a45ca416398c5942e135a00bed17a78297adf
> Cr-Commit-Position: refs/heads/master@{#395840}

Thank you, lgtm.

Powered by Google App Engine
This is Rietveld 408576698