Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 200613004: Test flakiness fix for form submission cancelable (Closed)

Created:
6 years, 9 months ago by Habib Virji
Modified:
6 years, 9 months ago
Reviewers:
keishi, tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Test flakiness fix for form submission cancelable Since test return will be aync, introduced function to test query string return value. This test fixes isuse introduced by fix for bug196640 R=keishi1, tkent BUG=353066 TEST=Automated Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169436

Patch Set 1 #

Total comments: 2

Patch Set 2 : Corrected wrong return value for second query in the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M LayoutTests/fast/forms/form-submission-cancelable.html View 1 2 chunks +15 lines, -7 lines 0 comments Download
M LayoutTests/fast/forms/form-submission-cancelable-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Habib Virji
Since value return will be async, a function to test return value. Added comment and ...
6 years, 9 months ago (2014-03-17 10:17:13 UTC) #1
tkent
https://codereview.chromium.org/200613004/diff/1/LayoutTests/fast/forms/form-submission-cancelable.html File LayoutTests/fast/forms/form-submission-cancelable.html (right): https://codereview.chromium.org/200613004/diff/1/LayoutTests/fast/forms/form-submission-cancelable.html#newcode22 LayoutTests/fast/forms/form-submission-cancelable.html:22: if (query === '?query=AAA' || query === '?query=BBB') { ...
6 years, 9 months ago (2014-03-17 20:56:19 UTC) #2
Habib Virji
Done. Apologise, I did test was query1, but by mistake deleted that 1. Thanks https://codereview.chromium.org/200613004/diff/1/LayoutTests/fast/forms/form-submission-cancelable.html ...
6 years, 9 months ago (2014-03-18 08:49:04 UTC) #3
tkent
lgtm
6 years, 9 months ago (2014-03-18 08:52:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/habib.virji@samsung.com/200613004/20001
6 years, 9 months ago (2014-03-18 08:52:36 UTC) #5
Habib Virji
On 2014/03/18 08:52:26, tkent wrote: > lgtm Thanks
6 years, 9 months ago (2014-03-18 08:53:35 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-18 09:51:53 UTC) #7
Message was sent while issue was closed.
Change committed as 169436

Powered by Google App Engine
This is Rietveld 408576698