New ordering of permissions in the Origin Info Bubble.

New ordering of permissions in the Origin Info Bubble.

Per Material Design refresh.

BUG=610358
Committed: https://crrev.com/7715e330567f9aab72ed070618723d533457207d
Cr-Commit-Position: refs/heads/master@{#396334}

[palmer, 2016-05-23 23:19:41]

palmer@chromium.org changed reviewers:
+ benwells@chromium.org

[palmer, 2016-05-23 23:19:41]

benwells: Can you please take a quick look? Thanks!

[benwells, 2016-05-24 01:46:05]

https://codereview.chromium.org/2006123002/diff/1/chrome/browser/ui/website_s...
File chrome/browser/ui/website_settings/website_settings.cc (right):

https://codereview.chromium.org/2006123002/diff/1/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/website_settings.cc:105:
CONTENT_SETTINGS_TYPE_PUSH_MESSAGING,
Can you remind me why this is in the list?

[palmer, 2016-05-24 18:25:56]

https://codereview.chromium.org/2006123002/diff/1/chrome/browser/ui/website_s...
File chrome/browser/ui/website_settings/website_settings.cc (right):

https://codereview.chromium.org/2006123002/diff/1/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/website_settings.cc:105:
CONTENT_SETTINGS_TYPE_PUSH_MESSAGING,
> Can you remind me why this is in the list?

No, because I don't know. :) See the comments from rolfe in the spreadsheet. It
sounds like we might coalesce push messaging permission with regular
notifications permission.

[palmer, 2016-05-24 18:26:32]

The spreadsheet is
https://docs.google.com/spreadsheets/d/1bVRBeEcJ3YSJNMKq9U9pm-dGFtVRDryzfojoD...
btw.

[benwells, 2016-05-25 00:51:36]

lgtm

https://codereview.chromium.org/2006123002/diff/1/chrome/browser/ui/website_s...
File chrome/browser/ui/website_settings/website_settings.cc (right):

https://codereview.chromium.org/2006123002/diff/1/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/website_settings.cc:105:
CONTENT_SETTINGS_TYPE_PUSH_MESSAGING,
On 2016/05/24 18:25:56, palmer wrote:
> > Can you remind me why this is in the list?
> 
> No, because I don't know. :) See the comments from rolfe in the spreadsheet.
It
> sounds like we might coalesce push messaging permission with regular
> notifications permission.

From some analysis and discussion with Tim we think this #if define is basically
dead - i.e. it could be removed without having any effect on anything.

Maybe we should do that in a separate CL though...

[palmer, 2016-05-26 22:17:47]

> From some analysis and discussion with Tim we think this #if define is
basically
> dead - i.e. it could be removed without having any effect on anything.
> 
> Maybe we should do that in a separate CL though...

Yeah, I'd vote for doing it in a separate CL.

[palmer, 2016-05-26 22:18:03]

The CQ bit was checked by palmer@chromium.org

[commit-bot: I haz the power, 2016-05-26 22:19:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2006123002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2006123002/1

[commit-bot: I haz the power, 2016-05-27 00:41:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-27 00:42:37]

Description was changed from

==========
New ordering of permissions in the Origin Info Bubble.

Per Material Design refresh.

BUG=610358
==========

to

==========
New ordering of permissions in the Origin Info Bubble.

Per Material Design refresh.

BUG=610358

Committed: https://crrev.com/7715e330567f9aab72ed070618723d533457207d
Cr-Commit-Position: refs/heads/master@{#396334}
==========

[commit-bot: I haz the power, 2016-05-27 00:42:38]

Patchset 1 (id:??) landed as
https://crrev.com/7715e330567f9aab72ed070618723d533457207d
Cr-Commit-Position: refs/heads/master@{#396334}