Allow hw secured codecs on chromecast

chromecast/browser/cast_content_window.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/browser/cast_content_window.h"
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/threading/thread_restrictions.h"
 #include "chromecast/base/metrics/cast_metrics_helper.h"
 #include "chromecast/browser/cast_browser_process.h"
+#include "chromecast/chromecast_features.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents.h"
+#include "content/public/common/renderer_preferences.h"
 #include "ipc/ipc_message.h"
 #include "ui/display/display.h"
 #include "ui/display/screen.h"
 
 #if defined(USE_AURA)
 #include "chromecast/graphics/cast_screen.h"
 #include "ui/aura/env.h"
 #include "ui/aura/layout_manager.h"
 #include "ui/aura/window.h"
 #include "ui/aura/window_tree_host.h"
@@ skipping 80 matching lines @@
   CHECK(display::Screen::GetScreen());
   gfx::Size display_size =
       display::Screen::GetScreen()->GetPrimaryDisplay().size();
 
   content::WebContents::CreateParams create_params(browser_context, NULL);
   create_params.routing_id = MSG_ROUTING_NONE;
   create_params.initial_size = display_size;
   content::WebContents* web_contents = content::WebContents::Create(
       create_params);
   content::WebContentsObserver::Observe(web_contents);
+
+#if !BUILDFLAG(DISABLE_DISPLAY)
+  content::RendererPreferences* prefs = web_contents->GetMutableRendererPrefs();
+  prefs->use_video_overlay_for_embedded_encrypted_video = true;

[ddorwin, 2016/05/24 22:05:41]

This is currently related directly to VIDEO_HOLE (and only used on Android via
AwSettings and Cast on Android). If Cast started using WMPI, this might create
unintended consequences (vs. the Ozone-based solution).

[yucliu1, 2016/05/24 22:26:33]

I found almost all the logics related to this boolean is inside android (except
the usage to select media key system config). Will the change break cast on
android or cast on all platforms (if cast use WMPI)?

Btw, what is WMPI, can you give some pointer?

[halliwell, 2016/05/24 22:51:02]

Yuchen: WMPI = WebMediaPlayerImpl
David, could you expand on your thoughts here?

This change doesn't affect Android or Cast on ATV as it stands, I think?  It's
making use of the same flag but on our linux+WMPI+Ozone pipeline.  Are you
talking about a future scenario where Cast on ATV starts using WMPI?

[ddorwin, 2016/05/24 23:11:50]

WMPI will soon be used for all EME content on Android (replacing WMPA).
Presumably, we will need to migrate the related WMPA logic there, which could
then have side effects on Chromecast.

At a higher level, though, this flag means "create a hole for EME video." That
is not necessarily the same thing as "use HW secure codecs," which we use as a
synonym for setting the security level in MediaDrmBridge.

+
+  content::RenderViewHost* host = web_contents->GetRenderViewHost();
+  if (host)
+    host->SyncRendererPrefs();
+#endif  // !BUILDFLAG(DISABLE_DISPLAY)
+
   return base::WrapUnique(web_contents);
 }
 
 void CastContentWindow::DidFirstVisuallyNonEmptyPaint() {
   metrics::CastMetricsHelper::GetInstance()->LogTimeToFirstPaint();
 }
 
 void CastContentWindow::MediaStoppedPlaying(const MediaPlayerId& id) {
   metrics::CastMetricsHelper::GetInstance()->LogMediaPause();
 }
 
 void CastContentWindow::MediaStartedPlaying(const MediaPlayerId& id) {
   metrics::CastMetricsHelper::GetInstance()->LogMediaPlay();
 }
 
 void CastContentWindow::RenderViewCreated(
     content::RenderViewHost* render_view_host) {
   content::RenderWidgetHostView* view =
       render_view_host->GetWidget()->GetView();
   if (view)
     view->SetBackgroundColor(transparent_ ? SK_ColorTRANSPARENT
                                           : SK_ColorBLACK);
 }
 
 }  // namespace shell
 }  // namespace chromecast