Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: mojo/dart/packages/mojo_services/lib/mojo/ui/view_provider.mojom.dart

Issue 2006093002: Dart: Futures -> Callbacks. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Move code from mojo_patch to proxy.dart Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/dart/packages/mojo_services/lib/mojo/ui/view_provider.mojom.dart
diff --git a/mojo/dart/packages/mojo_services/lib/mojo/ui/view_provider.mojom.dart b/mojo/dart/packages/mojo_services/lib/mojo/ui/view_provider.mojom.dart
index 6abe7b6c7c4f0d1d03ae2b2d14ade05f0761d171..345d21505a72f9c4696e7a49890002db0155e545 100644
--- a/mojo/dart/packages/mojo_services/lib/mojo/ui/view_provider.mojom.dart
+++ b/mojo/dart/packages/mojo_services/lib/mojo/ui/view_provider.mojom.dart
@@ -21,6 +21,11 @@ class _ViewProviderCreateViewParams extends bindings.Struct {
_ViewProviderCreateViewParams() : super(kVersions.last.size);
+ _ViewProviderCreateViewParams.init(
+ view_token_mojom.ViewOwnerInterfaceRequest this.viewOwner,
+ service_provider_mojom.ServiceProviderInterfaceRequest this.services
+ ) : super(kVersions.last.size);
+
static _ViewProviderCreateViewParams deserialize(bindings.Message message) {
var decoder = new bindings.Decoder(message);
var result = decode(decoder);
@@ -98,14 +103,17 @@ class _ViewProviderCreateViewParams extends bindings.Struct {
const int _viewProviderMethodCreateViewName = 0;
class _ViewProviderServiceDescription implements service_describer.ServiceDescription {
- dynamic getTopLevelInterface([Function responseFactory]) =>
- responseFactory(null);
+ void getTopLevelInterface(Function responder) {
+ responder(null);
+ }
- dynamic getTypeDefinition(String typeKey, [Function responseFactory]) =>
- responseFactory(null);
+ void getTypeDefinition(String typeKey, Function responder) {
+ responder(null);
+ }
- dynamic getAllTypeDefinitions([Function responseFactory]) =>
- responseFactory(null);
+ void getAllTypeDefinitions(Function responder) {
+ responder(null);
+ }
}
abstract class ViewProvider {
@@ -243,11 +251,11 @@ class _ViewProviderStubControl
- dynamic handleMessage(bindings.ServiceMessage message) {
+ void handleMessage(bindings.ServiceMessage message) {
if (bindings.ControlMessageHandler.isControlMessage(message)) {
- return bindings.ControlMessageHandler.handleMessage(this,
- 0,
- message);
+ bindings.ControlMessageHandler.handleMessage(
+ this, 0, message);
+ return;
}
if (_impl == null) {
throw new core.MojoApiError("$this has no implementation set");
@@ -262,7 +270,6 @@ class _ViewProviderStubControl
throw new bindings.MojoCodecError("Unexpected message name");
break;
}
- return null;
}
ViewProvider get impl => _impl;

Powered by Google App Engine
This is Rietveld 408576698