Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Unified Diff: mojo/dart/apptests/test_apps/echo/lib/main.dart

Issue 2006093002: Dart: Futures -> Callbacks. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Move code from mojo_patch to proxy.dart Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/dart/apptests/test_apps/echo/lib/main.dart
diff --git a/mojo/dart/apptests/test_apps/echo/lib/main.dart b/mojo/dart/apptests/test_apps/echo/lib/main.dart
index 4a203b9501f14cbb783c585225e28562f4182a51..45040a9758499bc3a543e3273b0ddfebcea01b6d 100644
--- a/mojo/dart/apptests/test_apps/echo/lib/main.dart
+++ b/mojo/dart/apptests/test_apps/echo/lib/main.dart
@@ -17,20 +17,20 @@ class EchoServiceImpl implements EchoService {
_service = new EchoServiceInterface.fromEndpoint(endpoint, this);
}
- dynamic echoString(String value, [Function responseFactory]) {
+ void echoString(String value, void callback(String value)) {
if (value == "quit") {
_service.close();
}
- return responseFactory(value);
+ callback(value);
}
- dynamic delayedEchoString(String value, int millis,
- [Function responseFactory]) {
+ void delayedEchoString(
+ String value, int millis, void callback(String value)) {
if (value == "quit") {
_service.close();
}
- return new Future.delayed(
- new Duration(milliseconds: millis), () => responseFactory(value));
+ new Future.delayed(
+ new Duration(milliseconds: millis), () => callback(value));
}
void swap() {

Powered by Google App Engine
This is Rietveld 408576698