Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1255)

Unified Diff: mojo/dart/packages/mojo_services/lib/notifications/notifications.mojom.dart

Issue 2006093002: Dart: Futures -> Callbacks. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Move code from mojo_patch to proxy.dart Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/dart/packages/mojo_services/lib/notifications/notifications.mojom.dart
diff --git a/mojo/dart/packages/mojo_services/lib/notifications/notifications.mojom.dart b/mojo/dart/packages/mojo_services/lib/notifications/notifications.mojom.dart
index 7cd6ce7ac0657a88c9e8901fcdb9c6189efd4d20..5fbe0e29a6d965251883df2a27282208d5196cd7 100644
--- a/mojo/dart/packages/mojo_services/lib/notifications/notifications.mojom.dart
+++ b/mojo/dart/packages/mojo_services/lib/notifications/notifications.mojom.dart
@@ -22,6 +22,14 @@ class NotificationData extends bindings.Struct {
NotificationData() : super(kVersions.last.size);
+ NotificationData.init(
+ String this.title,
+ String this.text,
+ bool this.playSound,
+ bool this.vibrate,
+ bool this.setLights
+ ) : super(kVersions.last.size);
+
static NotificationData deserialize(bindings.Message message) {
var decoder = new bindings.Decoder(message);
var result = decode(decoder);
@@ -145,6 +153,9 @@ class _NotificationClientOnSelectedParams extends bindings.Struct {
_NotificationClientOnSelectedParams() : super(kVersions.last.size);
+ _NotificationClientOnSelectedParams.init(
+ ) : super(kVersions.last.size);
+
static _NotificationClientOnSelectedParams deserialize(bindings.Message message) {
var decoder = new bindings.Decoder(message);
var result = decode(decoder);
@@ -203,6 +214,9 @@ class _NotificationClientOnDismissedParams extends bindings.Struct {
_NotificationClientOnDismissedParams() : super(kVersions.last.size);
+ _NotificationClientOnDismissedParams.init(
+ ) : super(kVersions.last.size);
+
static _NotificationClientOnDismissedParams deserialize(bindings.Message message) {
var decoder = new bindings.Decoder(message);
var result = decode(decoder);
@@ -262,6 +276,10 @@ class _NotificationUpdateParams extends bindings.Struct {
_NotificationUpdateParams() : super(kVersions.last.size);
+ _NotificationUpdateParams.init(
+ NotificationData this.notificationData
+ ) : super(kVersions.last.size);
+
static _NotificationUpdateParams deserialize(bindings.Message message) {
var decoder = new bindings.Decoder(message);
var result = decode(decoder);
@@ -334,6 +352,9 @@ class _NotificationCancelParams extends bindings.Struct {
_NotificationCancelParams() : super(kVersions.last.size);
+ _NotificationCancelParams.init(
+ ) : super(kVersions.last.size);
+
static _NotificationCancelParams deserialize(bindings.Message message) {
var decoder = new bindings.Decoder(message);
var result = decode(decoder);
@@ -395,6 +416,12 @@ class _NotificationServicePostParams extends bindings.Struct {
_NotificationServicePostParams() : super(kVersions.last.size);
+ _NotificationServicePostParams.init(
+ NotificationData this.notificationData,
+ NotificationClientInterface this.client,
+ NotificationInterfaceRequest this.notification
+ ) : super(kVersions.last.size);
+
static _NotificationServicePostParams deserialize(bindings.Message message) {
var decoder = new bindings.Decoder(message);
var result = decode(decoder);
@@ -486,14 +513,17 @@ const int _notificationClientMethodOnSelectedName = 0;
const int _notificationClientMethodOnDismissedName = 1;
class _NotificationClientServiceDescription implements service_describer.ServiceDescription {
- dynamic getTopLevelInterface([Function responseFactory]) =>
- responseFactory(null);
+ void getTopLevelInterface(Function responder) {
+ responder(null);
+ }
- dynamic getTypeDefinition(String typeKey, [Function responseFactory]) =>
- responseFactory(null);
+ void getTypeDefinition(String typeKey, Function responder) {
+ responder(null);
+ }
- dynamic getAllTypeDefinitions([Function responseFactory]) =>
- responseFactory(null);
+ void getAllTypeDefinitions(Function responder) {
+ responder(null);
+ }
}
abstract class NotificationClient {
@@ -639,11 +669,11 @@ class _NotificationClientStubControl
- dynamic handleMessage(bindings.ServiceMessage message) {
+ void handleMessage(bindings.ServiceMessage message) {
if (bindings.ControlMessageHandler.isControlMessage(message)) {
- return bindings.ControlMessageHandler.handleMessage(this,
- 0,
- message);
+ bindings.ControlMessageHandler.handleMessage(
+ this, 0, message);
+ return;
}
if (_impl == null) {
throw new core.MojoApiError("$this has no implementation set");
@@ -659,7 +689,6 @@ class _NotificationClientStubControl
throw new bindings.MojoCodecError("Unexpected message name");
break;
}
- return null;
}
NotificationClient get impl => _impl;
@@ -725,14 +754,17 @@ const int _notificationMethodUpdateName = 0;
const int _notificationMethodCancelName = 1;
class _NotificationServiceDescription implements service_describer.ServiceDescription {
- dynamic getTopLevelInterface([Function responseFactory]) =>
- responseFactory(null);
+ void getTopLevelInterface(Function responder) {
+ responder(null);
+ }
- dynamic getTypeDefinition(String typeKey, [Function responseFactory]) =>
- responseFactory(null);
+ void getTypeDefinition(String typeKey, Function responder) {
+ responder(null);
+ }
- dynamic getAllTypeDefinitions([Function responseFactory]) =>
- responseFactory(null);
+ void getAllTypeDefinitions(Function responder) {
+ responder(null);
+ }
}
abstract class Notification {
@@ -879,11 +911,11 @@ class _NotificationStubControl
- dynamic handleMessage(bindings.ServiceMessage message) {
+ void handleMessage(bindings.ServiceMessage message) {
if (bindings.ControlMessageHandler.isControlMessage(message)) {
- return bindings.ControlMessageHandler.handleMessage(this,
- 0,
- message);
+ bindings.ControlMessageHandler.handleMessage(
+ this, 0, message);
+ return;
}
if (_impl == null) {
throw new core.MojoApiError("$this has no implementation set");
@@ -901,7 +933,6 @@ class _NotificationStubControl
throw new bindings.MojoCodecError("Unexpected message name");
break;
}
- return null;
}
Notification get impl => _impl;
@@ -966,14 +997,17 @@ class NotificationStub
const int _notificationServiceMethodPostName = 0;
class _NotificationServiceServiceDescription implements service_describer.ServiceDescription {
- dynamic getTopLevelInterface([Function responseFactory]) =>
- responseFactory(null);
+ void getTopLevelInterface(Function responder) {
+ responder(null);
+ }
- dynamic getTypeDefinition(String typeKey, [Function responseFactory]) =>
- responseFactory(null);
+ void getTypeDefinition(String typeKey, Function responder) {
+ responder(null);
+ }
- dynamic getAllTypeDefinitions([Function responseFactory]) =>
- responseFactory(null);
+ void getAllTypeDefinitions(Function responder) {
+ responder(null);
+ }
}
abstract class NotificationService {
@@ -1112,11 +1146,11 @@ class _NotificationServiceStubControl
- dynamic handleMessage(bindings.ServiceMessage message) {
+ void handleMessage(bindings.ServiceMessage message) {
if (bindings.ControlMessageHandler.isControlMessage(message)) {
- return bindings.ControlMessageHandler.handleMessage(this,
- 0,
- message);
+ bindings.ControlMessageHandler.handleMessage(
+ this, 0, message);
+ return;
}
if (_impl == null) {
throw new core.MojoApiError("$this has no implementation set");
@@ -1131,7 +1165,6 @@ class _NotificationServiceStubControl
throw new bindings.MojoCodecError("Unexpected message name");
break;
}
- return null;
}
NotificationService get impl => _impl;

Powered by Google App Engine
This is Rietveld 408576698