Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: mojo/dart/apptests/dart_apptests/lib/src/pingpong_apptests.dart

Issue 2006093002: Dart: Futures -> Callbacks. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Merge Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/dart/apptests/dart_apptests/lib/src/pingpong_apptests.dart
diff --git a/mojo/dart/apptests/dart_apptests/lib/src/pingpong_apptests.dart b/mojo/dart/apptests/dart_apptests/lib/src/pingpong_apptests.dart
index 47b168002477e94c07e2d10e363fb5db6da89450..481972ab67c298a44a50deaf870f71f916034adf 100644
--- a/mojo/dart/apptests/dart_apptests/lib/src/pingpong_apptests.dart
+++ b/mojo/dart/apptests/dart_apptests/lib/src/pingpong_apptests.dart
@@ -63,9 +63,11 @@ pingpongApptests(Application application, String url) {
pingPongService.ctrl.errorFuture.then((e) => fail('$e'));
application.connectToService("mojo:dart_pingpong", pingPongService);
- var r = await pingPongService.pingTargetUrl(
- "mojo:dart_pingpong_target", 9);
- expect(r.ok, equals(true));
+ var c = new Completer();
+ pingPongService.pingTargetUrl("mojo:dart_pingpong_target", 9, (bool ok) {
+ c.complete(ok);
+ });
+ expect(await pingPongService.responseOrError(c.future), isTrue);
await pingPongService.close();
});
@@ -81,8 +83,12 @@ pingpongApptests(Application application, String url) {
targetService.ctrl.errorFuture.then((e) => fail('$e'));
application.connectToService("mojo:dart_pingpong_target", targetService);
- var r = await pingPongService.pingTargetService(targetService, 9);
- expect(r.ok, equals(true));
+ var c = new Completer();
+ pingPongService.pingTargetService(targetService, 9, (bool ok) {
+ c.complete(ok);
+ });
+ expect(await pingPongService.responseOrError(c.future), isTrue);
+
// This side no longer has access to the pipe.
expect(targetService.ctrl.isOpen, equals(false));
expect(targetService.ctrl.isBound, equals(false));

Powered by Google App Engine
This is Rietveld 408576698