Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: mojo/dart/packages/mojo_services/lib/tracing/trace_provider_registry.mojom.dart

Issue 2006093002: Dart: Futures -> Callbacks. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Merge Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/dart/packages/mojo_services/lib/tracing/trace_provider_registry.mojom.dart
diff --git a/mojo/dart/packages/mojo_services/lib/tracing/trace_provider_registry.mojom.dart b/mojo/dart/packages/mojo_services/lib/tracing/trace_provider_registry.mojom.dart
index 4bbe280d95b4f9877b9acff90b785fe6240e44f0..ebe41d704c8dafb650f44b3b066036595c431b9a 100644
--- a/mojo/dart/packages/mojo_services/lib/tracing/trace_provider_registry.mojom.dart
+++ b/mojo/dart/packages/mojo_services/lib/tracing/trace_provider_registry.mojom.dart
@@ -18,6 +18,10 @@ class _TraceProviderRegistryRegisterTraceProviderParams extends bindings.Struct
_TraceProviderRegistryRegisterTraceProviderParams() : super(kVersions.last.size);
+ _TraceProviderRegistryRegisterTraceProviderParams.init(
+ tracing_mojom.TraceProviderInterface this.traceProvider
+ ) : super(kVersions.last.size);
+
static _TraceProviderRegistryRegisterTraceProviderParams deserialize(bindings.Message message) {
var decoder = new bindings.Decoder(message);
var result = decode(decoder);
@@ -83,14 +87,17 @@ class _TraceProviderRegistryRegisterTraceProviderParams extends bindings.Struct
const int _traceProviderRegistryMethodRegisterTraceProviderName = 0;
class _TraceProviderRegistryServiceDescription implements service_describer.ServiceDescription {
- dynamic getTopLevelInterface([Function responseFactory]) =>
- responseFactory(null);
+ void getTopLevelInterface(Function responder) {
+ responder(null);
+ }
- dynamic getTypeDefinition(String typeKey, [Function responseFactory]) =>
- responseFactory(null);
+ void getTypeDefinition(String typeKey, Function responder) {
+ responder(null);
+ }
- dynamic getAllTypeDefinitions([Function responseFactory]) =>
- responseFactory(null);
+ void getAllTypeDefinitions(Function responder) {
+ responder(null);
+ }
}
abstract class TraceProviderRegistry {
@@ -240,11 +247,11 @@ class _TraceProviderRegistryStubControl
- dynamic handleMessage(bindings.ServiceMessage message) {
+ void handleMessage(bindings.ServiceMessage message) {
if (bindings.ControlMessageHandler.isControlMessage(message)) {
- return bindings.ControlMessageHandler.handleMessage(this,
- 0,
- message);
+ bindings.ControlMessageHandler.handleMessage(
+ this, 0, message);
+ return;
}
if (_impl == null) {
throw new core.MojoApiError("$this has no implementation set");
@@ -259,7 +266,6 @@ class _TraceProviderRegistryStubControl
throw new bindings.MojoCodecError("Unexpected message name");
break;
}
- return null;
}
TraceProviderRegistry get impl => _impl;

Powered by Google App Engine
This is Rietveld 408576698