chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc - Issue 2006083002: Use fake Input Device Settings with chrome://device-emulator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

Issue 2006083002: Use fake Input Device Settings with chrome://device-emulator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@DevicePageTestsFixes

Patch Set: make dependent on a11y fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/emulator/input_device_settings.js ('k') | chrome/browser/ui/webui/chromeos/emulator/device_emulator_message_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

diff --git a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

index 3f5436197b97e1b2590bd19640521e139e876bf5..9b986f74a03085877b9002bfc3af2cc8e486f9df 100644

--- a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

+++ b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

@@ -145,7 +145,7 @@

#include "components/proximity_auth/webui/url_constants.h"

#endif

-#if !defined(OFFICIAL_BUILD) && defined(OS_CHROMEOS) && !defined(NDEBUG)

+#if defined(OS_CHROMEOS) && !defined(NDEBUG)

#include "chrome/browser/ui/webui/chromeos/emulator/device_emulator_ui.h"

#endif

@@ -498,12 +498,12 @@ WebUIFactoryFunction GetWebUIFactoryFunction(WebUI* web_ui,

return &NewWebUI<chromeos::SlowTraceController>;

if (url.host() == chrome::kChromeUIVoiceSearchHost)

return &NewWebUI<VoiceSearchUI>;

-#if !defined(GOOGLE_CHROME_BUILD) && !defined(NDEBUG)

+#if !defined(NDEBUG)

if (!base::SysInfo::IsRunningOnChromeOS()) {

if (url.host() == chrome::kChromeUIDeviceEmulatorHost)

return &NewWebUI<DeviceEmulatorUI>;

}

-#endif // !defined(GOOGLE_CHROME_BUILD) && !defined(NDEBUG)

+#endif // !defined(NDEBUG)

#endif // defined(OS_CHROMEOS)

#if defined(OS_ANDROID)

if (url.host() == chrome::kChromeUIOfflineInternalsHost)