Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2006053006: Merge to M52: Ensure LegacyRenderWidgetHostHWND is always created. (Closed)

Created:
4 years, 7 months ago by dmazzoni
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Merge to M52: Ensure LegacyRenderWidgetHostHWND is always created. Previously, LegacyRenderWidgetHostHWND was only created inside RenderWidgetHostViewAura::InternalSetBounds, and only if the parent HWND was known. However, under some circumstances, InternalSetBounds only gets called once and it gets called *before* the aura Window is attached, so the legacy win never gets created. Fix it by also trying to create the legacy win in RWHVA::AddedToRootWindow(). BUG=613336 Review-Url: https://codereview.chromium.org/1996163002 Cr-Commit-Position: refs/heads/master@{#395649} (cherry picked from commit a7e78f6f5d453c52313b74de10c5f680aa3d5ee3) Committed: https://chromium.googlesource.com/chromium/src/+/686c6734e8d7b277dc252be0b209ecc24b9a46e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -37 lines) Patch
M content/browser/accessibility/accessibility_win_browsertest.cc View 3 chunks +44 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 3 chunks +28 lines, -35 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.h View 3 chunks +11 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dmazzoni
4 years, 7 months ago (2016-05-25 22:12:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
686c6734e8d7b277dc252be0b209ecc24b9a46e2.

Powered by Google App Engine
This is Rietveld 408576698